Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: move Notary contract out of P2PSigExtensions under Echidna hardfork #3478

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

core: prevent access to uninitialized NotaryAssisted fee

8871165
Select commit
Loading
Failed to load commit list.
Draft

*: move Notary contract out of P2PSigExtensions under Echidna hardfork #3478

core: prevent access to uninitialized NotaryAssisted fee
8871165
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 15, 2024 in 0s

86.13% (+0.04%) compared to c65d9f4

View this Pull Request on Codecov

86.13% (+0.04%) compared to c65d9f4

Details

Codecov Report

Attention: Patch coverage is 87.01299% with 10 lines in your changes missing coverage. Please review.

Project coverage is 86.13%. Comparing base (c65d9f4) to head (8871165).

Files Patch % Lines
pkg/core/blockchain.go 45.45% 3 Missing and 3 partials ⚠️
pkg/config/hardfork_string.go 0.00% 2 Missing ⚠️
pkg/core/interop/context.go 0.00% 1 Missing ⚠️
pkg/core/native/management.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3478      +/-   ##
==========================================
+ Coverage   86.08%   86.13%   +0.04%     
==========================================
  Files         330      330              
  Lines       38641    38657      +16     
==========================================
+ Hits        33266    33299      +33     
+ Misses       3835     3821      -14     
+ Partials     1540     1537       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.