-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlockFetcher/BlockUploader: fix and add additional attributes #3637
Conversation
5ffa157
to
ac7ef7c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3637 +/- ##
==========================================
- Coverage 83.32% 83.27% -0.06%
==========================================
Files 334 334
Lines 46446 46464 +18
==========================================
- Hits 38703 38691 -12
- Misses 6165 6205 +40
+ Partials 1578 1568 -10 ☔ View full report in Codecov by Sentry. |
Approved by accident, changes are required.
35d103b
to
bc8e52e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bc8e52e
to
6da7fd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM.
6da7fd5
to
b5a1887
Compare
|
Capitalize block objects and index file objects attributes. Add network magic attribute to container. Close #3631 Signed-off-by: Ekaterina Pavlova <[email protected]>
b5a1887
to
c47d4e6
Compare
Close #3631