Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NNS contract #266

Closed
wants to merge 17 commits into from
Closed

Update NNS contract #266

wants to merge 17 commits into from

Commits on Sep 14, 2022

  1. [nspcc-dev#266] nns: Add admin to properties 

    Follow the https://github.com/neo-project/non-native-contracts/blob/14f43ba8cf169323b61c23a3a701ac77d9a4e3eb/src/NameService/NameService.cs#L69.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    16aaaa6 View commit details
    Browse the repository at this point in the history

  2. [nspcc-dev#266] nns: Return empty Array from resolve instead of Null 

    In case if no records of the specified type found.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    80e5bcb View commit details
    Browse the repository at this point in the history

  3. [nspcc-dev#266] nns: Fix safe methods list 

    `getRecord` doesn't exist since
nspcc-dev@6ea4573.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    53e0e91 View commit details
    Browse the repository at this point in the history

  4. [nspcc-dev#266] nns: Return empty Array from getRecords instead of Null 

    And adjust method usages along the way.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    b584d5a View commit details
    Browse the repository at this point in the history

  5. [nspcc-dev#266] nns: Fix typo in the method description 

    Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    8213ba5 View commit details
    Browse the repository at this point in the history

  6. [nspcc-dev#266] nns: Restrict the maximum number of records with the … 

    …same type

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    b1f5864 View commit details
    Browse the repository at this point in the history

  7. [nspcc-dev#266] nns: Move common code to a separate method 

    Reuse getAllRecords for GetAllRecords.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    48c96ec View commit details
    Browse the repository at this point in the history

  8. [nspcc-dev#266] nns: Fix CNAME resolution rules 

    Do not include CNAME to the resulting list if we're looking for another
record type. If it's CNAME than it must be resolved.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    f65bbc0 View commit details
    Browse the repository at this point in the history

  9. [nspcc-dev#266] nns: Remove unused config file 

    Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    fe266fd View commit details
    Browse the repository at this point in the history

  10. [nspcc-dev#266] nns: Refactor record-related operations code 

    Do not move parts of SetRecord/AddRecord to a separate functions,
it makes the contract code more complicated. Also, improve
documentation a bit.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    22f2700 View commit details
    Browse the repository at this point in the history

  11. [nspcc-dev#266] nns: Move common record checking code to a separate f… 

    …unction

Don't repeat it each time.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    e5ad839 View commit details
    Browse the repository at this point in the history

  12. [nspcc-dev#266] nns: Accept token ID as an argument for storeRecord 

    It doesn't save VM opcodes, but allows to keep record key creation
logic in a single place which prevents the code from bugs appearance.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    86d171e View commit details
    Browse the repository at this point in the history

  13. [nspcc-dev#266] nns: Reuse storeRecord for storing SOA record 

    Less code repeating.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    b5d1b61 View commit details
    Browse the repository at this point in the history

  14. [nspcc-dev#266] nns: Move token key creation to a separate function 

    Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    2d8ba9d View commit details
    Browse the repository at this point in the history

  15. [nspcc-dev#266] nns: reuse existing context in tokenIDFromName 

    Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    c2e411c View commit details
    Browse the repository at this point in the history

  16. [nspcc-dev#266] nns: Keep isAvailable in sync with register 

    If conflicting records '*.domain' are present on new domain
registration, then `isAvailable` should return false for this
domain. Ref.
nspcc-dev@f25296b.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    6f49a54 View commit details
    Browse the repository at this point in the history

  17. [nspcc-dev#266] nns: Use millisecondsInSeconds constant where appropr… 

    …iate

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    37d5f56 View commit details
    Browse the repository at this point in the history