-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NNS update for 0.20.0 #419
Commits on Jul 29, 2024
-
Follow the https://github.com/neo-project/non-native-contracts/blob/14f43ba8cf169323b61c23a3a701ac77d9a4e3eb/src/NameService/NameService.cs#L69. Signed-off-by: Anna Shaleva <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dad079b - Browse repository at this point
Copy the full SHA dad079bView commit details -
nns: Remove unused config file
Signed-off-by: Anna Shaleva <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c732296 - Browse repository at this point
Copy the full SHA c732296View commit details -
nns: Fix typo in the method description
Signed-off-by: Anna Shaleva <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d77cfe5 - Browse repository at this point
Copy the full SHA d77cfe5View commit details -
nns: Restrict the maximum number of records with the same type
Signed-off-by: Anna Shaleva <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 51873d5 - Browse repository at this point
Copy the full SHA 51873d5View commit details -
nns: Move common code to a separate method
Reuse getAllRecords for GetAllRecords. Signed-off-by: Anna Shaleva <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c0b73a6 - Browse repository at this point
Copy the full SHA c0b73a6View commit details -
nns: Fix CNAME resolution rules
Do not include CNAME to the resulting list if we're looking for another record type. If it's CNAME than it must be resolved. Signed-off-by: Anna Shaleva <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9db9ace - Browse repository at this point
Copy the full SHA 9db9aceView commit details -
nns: Refactor record-related operations code
Do not move parts of SetRecord/AddRecord to a separate functions, it makes the contract code more complicated. Also, improve documentation a bit. Signed-off-by: Anna Shaleva <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9f4a35e - Browse repository at this point
Copy the full SHA 9f4a35eView commit details -
nns: use tokenID for setRecord operations
a.b.c.d can be an "a.b" record of "c.d" and can be "a" record of "b.c.d", the first one would fail to setRecord currently: at instruction 4287 (THROW): unhandled exception: "parent domain has expired" which is a 5758c84 regression. Signed-off-by: Roman Khimov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d677c66 - Browse repository at this point
Copy the full SHA d677c66View commit details -
nns: Move common record checking code to a separate function
Don't repeat it each time. Signed-off-by: Anna Shaleva <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7255441 - Browse repository at this point
Copy the full SHA 7255441View commit details -
nns: Accept token ID as an argument for storeRecord
It doesn't save VM opcodes, but allows to keep record key creation logic in a single place which prevents the code from bugs appearance. Signed-off-by: Anna Shaleva <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 224936c - Browse repository at this point
Copy the full SHA 224936cView commit details -
nns: Reuse storeRecord for storing SOA record
Less code repeating. Signed-off-by: Anna Shaleva <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 78862e4 - Browse repository at this point
Copy the full SHA 78862e4View commit details -
nns: Move token key creation to a separate function
Signed-off-by: Anna Shaleva <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c8825a1 - Browse repository at this point
Copy the full SHA c8825a1View commit details -
nns: reuse existing context in tokenIDFromName
Signed-off-by: Anna Shaleva <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 836a5de - Browse repository at this point
Copy the full SHA 836a5deView commit details -
nns: Keep
isAvailable
in sync withregister
If conflicting records '*.domain' are present on new domain registration, then `isAvailable` should return false for this domain. Ref. f25296b. Signed-off-by: Anna Shaleva <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1bb8b1c - Browse repository at this point
Copy the full SHA 1bb8b1cView commit details -
nns: Use millisecondsInSeconds constant where appropriate
Signed-off-by: Anna Shaleva <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8f751bc - Browse repository at this point
Copy the full SHA 8f751bcView commit details
Commits on Jul 30, 2024
-
nns: limit max number of records to 16
These numbers are pretty much arbitrary, but we currently don't need more than that. Signed-off-by: Roman Khimov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 22be33c - Browse repository at this point
Copy the full SHA 22be33cView commit details -
nns: separate "too long name" from other errors
Part of #411. Signed-off-by: Roman Khimov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 650a7dc - Browse repository at this point
Copy the full SHA 650a7dcView commit details -
nns: simplify checks on split, use different errors
1. splitAndCheck doesn't need allowMultipleFragments since there is exactly one user of it and it checks for the number of fragments anyway. 2. We can panic right inside of it with a bit more details, nil fragments are never valid. 3. Except for one case in checkRecord where the error must be different, so safeSplitAndCheck is introduced. Fixes #411. Signed-off-by: Roman Khimov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6dfd53b - Browse repository at this point
Copy the full SHA 6dfd53bView commit details -
tests: fix sporadic container test failure
Sometimes 10 is exactly the value, so changing it doesn't make the ID different: Error Trace: /home/runner/go/pkg/mod/github.com/nspcc-dev/[email protected]/pkg/neotest/basic.go:218 /home/runner/go/pkg/mod/github.com/nspcc-dev/[email protected]/pkg/neotest/client.go:108 /home/runner/work/neofs-contract/neofs-contract/tests/container_test.go:237 Error: Not equal: expected: 0x1 actual : 0x2 Test: TestContainerPut/standard_deploy/with_nice_names/register_in_advance Messages: at instruction 2149 (THROW): unhandled exception: "container was previously deleted" Signed-off-by: Roman Khimov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e5d3659 - Browse repository at this point
Copy the full SHA e5d3659View commit details