NNS update rebased #420
Open
NNS update rebased #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case if no records of the specified type found. Signed-off-by: Anna Shaleva <[email protected]>
And adjust method usages along the way. Signed-off-by: Anna Shaleva <[email protected]>
roman-khimov
force-pushed
the
nns-upd-rebased
branch
from
46e39d0
to
26fa0a0
Compare
|
Rebase? |
|
Doesn't matter much at this stage. |
|
Is it post-release? |
|
That's why it's not a part of #419, see above. |
|
I see it is (was) based on #419 and has some additional changes but I do not see an explanation as to why not add it to the release. Dont mind though. |
|
Because of API changes, #266 (review). |
|
as well as i'd like to ask in #266 - pls describe motivation in the commits. Now it looks like "lets change just like that", but the behavior of the contract changes. Mb @AnnaShaleva will remind us being an original author |
carpawell
reviewed
Aug 9, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a rebase of #266 with some additions. It largely intersects with #419, but has two additional ones. Not intended to be merged immediately.