Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm/Deprecated 0.37.0 config and metrics #2400

Merged
merged 3 commits into from
Jun 21, 2023
Merged

rm/Deprecated 0.37.0 config and metrics #2400

merged 3 commits into from
Jun 21, 2023

Conversation

notimetoname
Copy link
Contributor

Closes #2347.

@notimetoname notimetoname self-assigned this Jun 20, 2023
@notimetoname notimetoname force-pushed the rm/deprecated-0.37.0-config branch 2 times, most recently from c68ec32 to 38decb7 Compare June 20, 2023 16:14
@notimetoname notimetoname marked this pull request as ready for review June 20, 2023 16:14
@roman-khimov
Copy link
Member

BTW, looks like we still have some rpc_endpoint reference in docs.

@codecov
Copy link

codecov bot commented Jun 21, 2023 •
edited
Loading

Codecov Report

Merging #2400 (1f835b8) into master (cfb7822) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 1f835b8 differs from pull request most recent head 10eb098. Consider uploading reports for the commit 10eb098 to get more accurate results

@@            Coverage Diff             @@
##           master    #2400      +/-   ##
==========================================
- Coverage   30.14%   30.12%   -0.02%     
==========================================
  Files         399      399              
  Lines       29868    29850      -18     
==========================================
- Hits         9004     8993      -11     
+ Misses      20134    20127       -7     
  Partials      730      730
Impacted Files Coverage Δ
pkg/innerring/innerring.go 0.00% <ø> (ø)
cmd/neofs-node/config/morph/config.go 100.00% <100.00%> (+2.94%) ⬆️
pkg/innerring/config.go 97.67% <100.00%> (-0.03%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

roman-khimov
roman-khimov reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amd:?

@notimetoname
Copy link
Contributor Author

@roman-khimov, dont like intel.

@roman-khimov roman-khimov merged commit 85a31ff into nspcc-dev:master Jun 21, 2023
@notimetoname notimetoname deleted the rm/deprecated-0.37.0-config branch June 21, 2023 14:17
@notimetoname notimetoname mentioned this pull request Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

Assignees

@notimetoname notimetoname

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop deprecated metrics
2 participants
@notimetoname @roman-khimov