rm/Drop subnets support #2411
rm/Drop subnets support #2411
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2411 +/- ##
==========================================
+ Coverage 29.23% 29.69% +0.46%
==========================================
Files 406 399 -7
Lines 30863 29938 -925
==========================================
- Hits 9023 8891 -132
+ Misses 21098 20309 -789
+ Partials 742 738 -4
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
red dawn 🟥
@notimetoname about deprecation: imo it's better to insta purge all stuff since afaik the feature has never been used
Agree with that. |
|
@roman-khimov, @cthulhu-rider, ok, it is ready then. Also, pay attention to regenerated files (e.g.). I used to install the same versions not to add useless changes to version lines in the files but after the 10th time, I do not want to do it anymore. |
notimetoname
force-pushed
the
rm/subnets
branch
2 times, most recently
from
d42e1b4
to
4dea601
Compare
See nspcc-dev/neofs-api#261. Signed-off-by: Pavel Karpy <[email protected]>
Make them be a few logical sections (not a list, not a text with paragraphs). Also, make them be named "Updating" (not "Upgrading" like they used to be but were renamed for some unknown reason). Signed-off-by: Pavel Karpy <[email protected]>
See nspcc-dev/neofs-api#261.
@cthulhu-rider, @roman-khimov, ping me if you think that it should be deprecated first (CLI flags, subcommands).