Deploy/update NeoFS contracts automatically within Sidechain deployment procedure #2444

cthulhu-rider · 2023-07-18T06:42:59Z

continue Bundle neofs-contracts into IR nodes #2195

thoughts/ideas not implemented in the current PR:

according to introduced deploy mechanics, all contracts may be deployed/updated in parallel
for single contract, when contract is deployed, update procedure and NNS registration may be done in parallel because its hash doesn't change
in existing networks, we share committee group key in other way. Current procedure expects that bootstrap domain exists in the NNS: that is not done in existing networks, so we should adapt to this situation
some pieces of code may be shared (role designation, update functionality, etc.), but i'd postpone refactoring after functional stabilization
NeoFSAlphabet role is designated to all committee members, i don't any reason why not (at least at the deployment stage)

on all points, I propose to leave the issue and decide separately

codecov · 2023-07-18T06:45:47Z

Codecov Report

Merging #2444 (d4b321f) into master (6b077ad) will decrease coverage by 0.68%.
The diff coverage is 11.65%.

❗ Current head d4b321f differs from pull request most recent head 3dad944. Consider uploading reports for the commit 3dad944 to get more accurate results

@@            Coverage Diff             @@
##           master    #2444      +/-   ##
==========================================
- Coverage   29.21%   28.53%   -0.68%     
==========================================
  Files         416      421       +5     
  Lines       31330    32481    +1151     
==========================================
+ Hits         9154     9270     +116     
- Misses      21377    22402    +1025     
- Partials      799      809      +10

Files	Coverage Δ
cmd/neofs-adm/internal/modules/config/config.go	`30.00% <100.00%> (-0.99%)`	⬇️
cmd/neofs-adm/internal/modules/morph/generate.go	`36.84% <100.00%> (+0.55%)`	⬆️
pkg/util/glagolitsa/glagolitsa.go	`100.00% <100.00%> (ø)`
...fs-adm/internal/modules/morph/initialize_deploy.go	`0.00% <0.00%> (ø)`
cmd/neofs-adm/internal/modules/morph/initialize.go	`0.00% <0.00%> (ø)`
pkg/util/state/storage.go	`85.00% <92.30%> (+7.22%)`	⬆️
pkg/innerring/state.go	`0.00% <0.00%> (ø)`
pkg/morph/client/nns.go	`0.00% <0.00%> (ø)`
pkg/innerring/alphabet.go	`0.00% <0.00%> (ø)`
pkg/innerring/config.go	`96.34% <93.65%> (-1.33%)`	⬇️
... and 12 more

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

pkg/morph/deploy/util.go

roman-khimov · 2023-07-31T20:38:43Z

pkg/morph/deploy/contracts.go

+
+	var managementContract *management.Contract
+	if prm.committeeDeployRequired {
+		deployCommitteeActor, err := newCommitteeNotaryActorWithScope(prm.blockchain, prm.localAcc, prm.committee, transaction.Global)


Do you need Global here?

container contract is deployed with global only during testing. What scope do u expect to work?

CalledByEntry, at least if it's not doing some calls in _deploy().

Container contract calls NNS one on _deploy https://github.com/nspcc-dev/neofs-contract/blob/84ff5d244f6913987c2fb7dc3e2adfb5dfa81381/container/container_contract.go#L170

should CalledByEntry be enough?

tried, got

failed to send Notary request deploying the contract, will try again later {"contract": "NeoFS Container", "domain": "container.neofs", "error": "script failed (FAULT state) due to an error: at instruction 8 (SYSCALL): failed native call: at instruction 5043 (THROW): unhandled exception: \"not witnessed by committee\""}

Can be done with CustomContracts or Rules, but OK to be a separate issue.

CustomContracts works, changed

didn't check Rules

roman-khimov · 2023-07-31T20:40:57Z

pkg/morph/deploy/contracts.go

+
+			l.Error("could not read on-chain state of the contract by NNS domain name, trying by pre-calculated address...")
+
+			preCalculatedAddr := state.CreateContractHash(prm.localAcc.ScriptHash(), prm.localNEF.Checksum, prm.localManifest.Name)


Sometimes you deploy from committee, is it correct always using localAcc here?

i think yes: transaction sender should always be the same acc (to keep hash predictable), so, even if committee multisig is required, we calculate hash from simple acc. What do u think?

btw Actor provides Sender() interface, so it may be useful here

btw Actor provides Sender() interface, so it may be useful here

Yes, use it here, it'll be helpful if we're to change the signers in the future.

pkg/morph/deploy/contracts.go

pkg/morph/deploy/deploy.go

roman-khimov · 2023-07-31T20:53:22Z

pkg/morph/deploy/deploy.go

+	syncPrm.localManifest = prm.AlphabetContract.Common.Manifest
+	syncPrm.anyValidExtraDeployArgs = []interface{}{false, util.Uint160{}, util.Uint160{}, "az", 0, 0}
+	syncPrm.buildVersionedExtraUpdateArgs = func(versionOnChain contractVersion) ([]interface{}, error) {
+		if versionOnChain.equals(0, 17, 0) {


Why do you care about on-chain version if _deploy will be called after the update?

iiuc ur question: because on-update _deploy callback is executed with on-chain version which may require some args (like this one). If _deploy throws exception then contract isn't updated, right?

on-update _deploy callback is executed with on-chain version

Why? It's called after the update. If you mean arguments, then yes, that's what our update methods do (add on-chain version to control upgrades), but the _deploy implementation is going to be from the new contract and you need to provide arguments valid for this new version, not the one you have before the upgrade.

that's a suprise to me, will fix

roman-khimov · 2023-07-31T20:56:25Z

pkg/morph/deploy/deploy.go

+	}
+
+	// we attempt to deploy contracts other than Alphabet ones by single committee
+	// member (1st for simplicity) to reduce the likelihood of contract duplication


I'm not sure it's a good approach. Old IR nodes can break with some new contracts, so we better have a BFT number of new ones.

this statement is about "prevent multiple instances of contracts of the same version". Not sure i got ur point

Does it affect deployments only or upgrades as well? It's OK to have az leading during deployment, but for upgrades it's a little more dangerous.

For upgrades we've ended up on a definite round-robin solution (ref. #2417 (comment)), but I'm not sure that this solution is implemented here. @cthulhu-rider?

affects deployment only, upgrades are parallel

roman-khimov · 2023-07-31T20:59:07Z

pkg/morph/deploy/deploy.go

+		[]byte(netmap.IrCandidateFeeConfig), encodeUintConfig(prm.NetmapContract.Config.IRCandidateFee),
+		[]byte(netmap.WithdrawFeeConfig), encodeUintConfig(prm.NetmapContract.Config.WithdrawalFee),
+		[]byte(netmap.HomomorphicHashingDisabledKey), encodeBoolConfig(prm.NetmapContract.Config.HomomorphicHashingDisabled),
+		[]byte(netmap.MaintenanceModeAllowedConfig), encodeBoolConfig(prm.NetmapContract.Config.MaintenanceModeAllowed),


Where do we get default values from for these? How about preserving them on update?

i thought we'll get exact values (incl. defaults) from neofs-ir app config

Well, it doesn't have them.

will be implemented with integration in app

pkg/morph/deploy/deploy.go

pkg/morph/deploy/alphabet.go

carpawell · 2023-08-07T17:37:44Z

pkg/morph/deploy/contracts.go

+//
+// Returns address of the on-chain contract synchronized with the record of the
+// NNS domain with parameterized name.
+func syncNeoFSContract(ctx context.Context, prm syncNeoFSContractPrm) (util.Uint160, error) {


300+ lines long func, up to 7 level nesting. can it be simplified?

dont wanna do this right now, otherwise there will be more funcs called once accepting a lot of parameters

more funcs called once

have nothing against it. there are a lot of linters that ask to keep functions easier does not matter they may be called once

accepting a lot of parameters

without a context, i would say smth bad is happening in general then. and functions are not the key reasons for that

have nothing agains synthesize funcs that are well documented and their purpose is more than just to reduce the size of other functions. But, at the same time, i prefer to do refactor when behavior is approved and stable, and everything is well-tested

and tbh this func isnt too big: there are a lot of logs+whitespace, all actions are done in for loop and there aint many of them. Ofc linter says function is ugly, but any fella will figure it out i bet

up to 7 level nesting

lie, up to 4-5

behavior is approved and stable

it is hard to approve smth that hard to keep in mind

any fella will figure it out i bet

any code (that can be compiled) can be understood. that is the reading/time question

lie, up to 4-5

you pushed code 7+ times since, why the numbers are so necessary? "lie"? 6 tabs, the behavior changing keyword (continue) is the seventh in the func's context

AnnaShaleva · 2023-08-15T13:35:29Z

pkg/morph/client/netmap/config.go

+	EpochDurationConfig           = "EpochDuration"
+	ContainerFeeConfig            = "ContainerFee"
+	ContainerAliasFeeConfig       = "ContainerAliasFee"
+	EtIterationsConfig            = "EigenTrustIterations"


s/EtIterationsConfig/ETIterationsConfig

AnnaShaleva · 2023-08-15T13:35:46Z

pkg/morph/client/netmap/config.go

+	ContainerFeeConfig            = "ContainerFee"
+	ContainerAliasFeeConfig       = "ContainerAliasFee"
+	EtIterationsConfig            = "EigenTrustIterations"
+	EtAlphaConfig                 = "EigenTrustAlpha"


s/EtAlphaConfig/ETAlphaConfig

AnnaShaleva · 2023-08-15T13:36:07Z

pkg/morph/client/netmap/config.go

+	ContainerAliasFeeConfig       = "ContainerAliasFee"
+	EtIterationsConfig            = "EigenTrustIterations"
+	EtAlphaConfig                 = "EigenTrustAlpha"
+	IrCandidateFeeConfig          = "InnerRingCandidateFee"


s/IrCandidateFeeConfig/IRCandidateFeeConfig

AnnaShaleva · 2023-08-15T13:56:20Z

pkg/morph/deploy/alphabet.go

+			continue
+		}
+
+		someoneWithoutRole := len(accsWithAlphabetRole) < len(prm.committee)


Shouldn't we check the precise members match? I.e. we can have the exact len(ptm.committee) number of designated alphabet nodes, but the pubs may differ from the desired.

we check this in the next condition

Then this one can be removed?

afaik designateAsRole sets member list not adds ones. So, when this condition is true, we don't actually need to know what exact keys are missing and we skip loop above

AnnaShaleva · 2023-08-15T14:00:52Z

pkg/morph/deploy/alphabet.go

+		tx, err := roleContract.DesignateAsRoleTransaction(noderoles.NeoFSAlphabet, prm.committee)
+		if err != nil {
+			prm.logger.Error("failed to make transaction designating NeoFS Alphabet role to the committee, will try again later", zap.Error(err))
+			continue
+		}
+
+		mainTxID, fallbackTxID, vub, err := committeeActor.Notarize(tx, nil)


You can use committeeActor.Notarize(roleContract.DesignateAsRoleTransaction(noderoles.NeoFSAlphabet, prm.committee)), and if error happens, then it will be properly formatted anyway.

AnnaShaleva · 2023-08-15T14:53:13Z

pkg/morph/deploy/contracts.go

+
+			l.Info("sending new transaction registering domain in the NNS...")
+
+			txID, vub, err := localActor.SendCall(prm.nnsContract, methodNNSRegister,


Maybe we can at least register and transfer to alphabet address immediately (in the same transaction)?

LGTM, this change is atomic and allows not to worry about the domain owner in future. However, if committee is updated, then we have to transfer the domain from the old committee address to the new one (IINM, currently this code is absent from the node implementation).

AnnaShaleva · 2023-08-15T14:55:18Z

pkg/morph/deploy/contracts.go

+
+			l.Info("sending new transaction registering domain in the NNS...")
+
+			txID, vub, err := localActor.SendCall(prm.nnsContract, methodNNSRegister,


And BTW, can't we include the domain record addition into the same transaction? Currently it's done in a separate transaction.

AnnaShaleva · 2023-08-15T14:59:35Z

pkg/morph/deploy/deploy.go

+		if err != nil {
+			// contract may be deployed but not registered in the NNS yet
+			if localAccLeads && (errors.Is(err, errMissingDomain) || errors.Is(err, errMissingDomainRecord)) {
+				return state.CreateContractHash(prm.LocalAccount.ScriptHash(), commonPrm.NEF.Checksum, commonPrm.Manifest.Name), nil


But what if it's not the local account who was deployed the contract? What if it's another committee member was managed to deploy it earlier?

i can suggest only one alternative: iterate over all contracts, meet first with the same name in manifest and that's it. Btw i've already done this before, but, taking into account that we expect fixed committee during initial deployment and that searching by manifest name isn't protected from the race, I abandoned this approach

i have no ideas about other alternatives

thoughts?

AnnaShaleva · 2023-08-15T15:09:13Z

pkg/morph/deploy/deploy.go

+	for ind := 0; ind < len(committee) && ind < glagolitsaSize; ind++ {
+		syncPrm.tryDeploy = ind == localAccCommitteeIndex // each member deploys its own Alphabet contract
+		syncPrm.domainName = calculateAlphabetContractAddressDomain(ind)
+		syncPrm.buildExtraDeployArgs = func() ([]interface{}, error) {
+			netmapContractAddress, err := resolveContractAddressDynamically(prm.NetmapContract.Common, domainNetmap)


But why are we trying to deploy Alphabet from every member? Why can't we preserve a single deployment initiator for a cirtain time period like it is done for the rest of the contracts?

because we have N per-member Alphabet contracts that are completely the same, so afaik to reach N entries we must vary deployer, right?

AnnaShaleva · 2023-08-15T15:11:27Z

pkg/morph/deploy/deploy.go

+	}
+
+	// we attempt to deploy contracts other than Alphabet ones by single committee
+	// member (1st for simplicity) to reduce the likelihood of contract duplication


For upgrades we've ended up on a definite round-robin solution (ref. #2417 (comment)), but I'm not sure that this solution is implemented here. @cthulhu-rider?

cthulhu-rider · 2023-10-23T10:02:37Z

Needs a rebase (conflicts) and contracts 0.18.0 (commit says it's from some "master").

updated, still works (checked on 4x node neo-go env)

It's worth to make these constants reusable. Signed-off-by: Leonard Lyubich <[email protected]>

Previously, `readContractLocalVersion` didn't pass extra arguments to deploy method. This was normal for the NNS contract, but some other system contracts would fail without the args. The function accepts optional data from now. Another drawback: if contract already exists (deployed earlier), `deploy` method throws `contract already exists` exception. To avoid this, dummy (zero) signer is used as a sender which almost definitely doesn't collide with the real one. One more disadvantage: function didn't add committee signers to deploy invocation. For some contracts that require committee witness for deployment (e.g. Container) version reader could not execute. To cover this, the function now accepts committee members and, for simplicity, always attach them as deployent transaction's signers. Signed-off-by: Leonard Lyubich <[email protected]>

Extend Sidechain deployment procedure with Alphabet initialization and deployment/update of all system NeoFS contracts except NNS (implemented earlier). Glagolitic script is moved to shared package in order to reuse it between different applications. Refs nspcc-dev#2195. Signed-off-by: Leonard Lyubich <[email protected]>

Some actions of committee group distribution routine are similar for all domains, so it's redundant to repeat same failed ops for other domains. Signed-off-by: Leonard Lyubich <[email protected]>

Drop additional pre-checks of contract checksums and versions, and perform active `update` method call which can throw `already updated` exception. Signed-off-by: Leonard Lyubich <[email protected]>

Signed-off-by: Leonard Lyubich <[email protected]>

In order to prevent duplication of update transactions, there is a need to sync nonce and ValidUntilBlock values in a distributed manner. Since Sidechain is tied to the particular running NeoFS network, and update procedure is performed during its lifetime, it makes sense to base these variables to the network state. For all update transactions, set: * nonce to the current NeoFS epoch; * ValidUntilBlock to E+100, where E is a height of the Sidechain at which the current epoch began. Signed-off-by: Leonard Lyubich <[email protected]>

Previously, update procedure calculated extra update arguments according to the on-chain version for each contract. This didn't make any sense because update callback (`_deploy` function in contract sources) is known in advance and called around new version of the contract (in this context, on-chain version is previous). Drop `contractVersion` parameter from update data constructors. Signed-off-by: Leonard Lyubich <[email protected]>

Previously, NeoFS contracts deployed in free order. In order to avoid potential dependency or stability issues, it's worth to make deployment in a fixed and clearly defined sequence. Signed-off-by: Leonard Lyubich <[email protected]>

Previously, Sidechain deployment procedure registered contract domain in the NNS and set its record in two separate transactions. According to `register` method that doesn't fail if requested domain already exists, nothing prevents us to stick both actions together into single transaction. Make `syncNeoFSContract` to concatenate scripts of `register` and `addRecord` calls and send single transaction with the result. Signed-off-by: Leonard Lyubich <[email protected]>

Make Sidechain deployment procedure to register 'group.neofs' domain with public key of the committee group. Register functionality is almost the same (different domain name and record format) as for contract addresses, so it's shared in new helper function. Signed-off-by: Leonard Lyubich <[email protected]>

Initially, all Sidechain GAS is owned by the validator multi-sig account. We need to distribute this GAS between the committee (multi-sig account and single ones) for initial deployment. It doesn't make sense to leave GAS on validator account. Add stage following Notary service initialization that: * preserves at least 150GAS (initially 300GAS) on each committee member's account * preserves (almost) all remaining GAS on the committee multi-sig account (keeps 10GAS on validator acc to pay transfer fees) * preserves all available NEO on the committee multi-sig acc Notary requests with transactions to be signed by the validator multi-sig account are also supported in the listening routine. Signed-off-by: Leonard Lyubich <[email protected]>

Proxy contact pays for main transactions sent using Notary service, so it needs a lot of GAS to do so. Transfer 90% of GAS from the committee multi-sig account to the Proxy contract if it has no GAS. Later replenishments are done by NeoFS GAS emission cycles. Signed-off-by: Leonard Lyubich <[email protected]>

Prevent double processing. Support different number and order of signers. Skip transactions that have already been signed by the local account. Log main transaction hash. Signed-off-by: Leonard Lyubich <[email protected]>

All NeoFS Alphabet (i.e. committee) members must be registered as candidates to Sidechain validators. This is vital for NeoFS network processing. Extended Sidechain deployment procedure with registration stage. It sends one transaction witnessed by committee multi-sig (to temporary minimize registration price) and each individual Alphabet member (required by Neo contract). Signed-off-by: Leonard Lyubich <[email protected]>

…acts Make Sidechain deployment procedure to evenly distribute all available NEO tokens between deployed NeoFS Alphabet contracts. Signed-off-by: Leonard Lyubich <[email protected]>

Make NeoFS Inner Ring application to perform Sidechain auto-deployment (incl. contracts' update) on each run in local consensus mode. Embedded contracts are built from v0.18.0 revision of NeoFS Contracts with updated NNS behavior (TLDs owned by the committee). Refs nspcc-dev#2195. Signed-off-by: Leonard Lyubich <[email protected]>

Previously, floating point numbers were successfully parsed into integers: mantissa were silently dropped. This behavior could lead to false-positive acceptance of the incorrect configuration. Check floating point separately as a workaround for missing check in `viper` library. Signed-off-by: Leonard Lyubich <[email protected]>

Despite the fact that the committee consists of one member, the transaction must be witnessed by a multi-sig 1:1 account. Signed-off-by: Leonard Lyubich <[email protected]>

Simple local and committee multi-sig notary actors are used in all `syncNeoFSContract` calls, so it's worth to create them once and share. Signed-off-by: Leonard Lyubich <[email protected]>

Signed-off-by: Leonard Lyubich <[email protected]>

Previously, updating transactions of the NeoFS smart contracts (calling `update` method) were sent with ValidUntilBlock set to last epoch block + 100 by the sidechain auto-deployment procedure. This could cause the update idleness when epoch duration was more than 100 Sidechain blocks. To prevent this, the transaction should be valid at least one epoch time. Refs nspcc-dev#2195. Signed-off-by: Leonard Lyubich <[email protected]>

cthulhu-rider · 2023-11-10T10:22:17Z

rebased and checked again on neo-go and neofs dev env

cthulhu-rider requested a review from AnnaShaleva July 18, 2023 06:42

cthulhu-rider requested review from roman-khimov and carpawell as code owners July 18, 2023 06:43

cthulhu-rider marked this pull request as draft July 18, 2023 06:43

cthulhu-rider force-pushed the feature/deploy-sys-contracts branch from 3dd9463 to 6365616 Compare July 18, 2023 06:44

cthulhu-rider marked this pull request as ready for review July 18, 2023 08:16

cthulhu-rider marked this pull request as draft July 18, 2023 08:17

cthulhu-rider force-pushed the feature/deploy-sys-contracts branch from 6365616 to e8b560d Compare July 18, 2023 12:55

cthulhu-rider marked this pull request as ready for review July 18, 2023 14:46

roman-khimov reviewed Jul 31, 2023

View reviewed changes

carpawell reviewed Aug 7, 2023

View reviewed changes

cthulhu-rider force-pushed the feature/deploy-sys-contracts branch from 41384e9 to 039e0f2 Compare August 9, 2023 14:51

AnnaShaleva reviewed Aug 15, 2023

View reviewed changes

cthulhu-rider marked this pull request as draft August 16, 2023 07:03

cthulhu-rider mentioned this pull request Aug 17, 2023

NPE in WebSocket client subscriptions nspcc-dev/neo-go#3093

Closed

cthulhu-rider force-pushed the feature/deploy-sys-contracts branch 10 times, most recently from 95ba5b1 to 6b57741 Compare August 24, 2023 07:48

cthulhu-rider force-pushed the feature/deploy-sys-contracts branch 4 times, most recently from 13e19c4 to 2316623 Compare August 28, 2023 18:27

cthulhu-rider force-pushed the feature/deploy-sys-contracts branch from cfba68b to ac4bf9d Compare October 23, 2023 09:27

cthulhu-rider added 16 commits November 10, 2023 10:15

sidechain/netmap: Export configuration key constants

e2216fa

It's worth to make these constants reusable. Signed-off-by: Leonard Lyubich <[email protected]>

sidechain/deploy: Do not repeat already failed actions within one block

daa2af1

Some actions of committee group distribution routine are similar for all domains, so it's redundant to repeat same failed ops for other domains. Signed-off-by: Leonard Lyubich <[email protected]>

sidechain/deploy: Perform active update attempt for the NNS contract

6e29fda

Drop additional pre-checks of contract checksums and versions, and perform active `update` method call which can throw `already updated` exception. Signed-off-by: Leonard Lyubich <[email protected]>

sidechain/deploy: Make Proxy contract to pay for update transactions

c53628b

Signed-off-by: Leonard Lyubich <[email protected]>

sidechain/deploy: Deploy contracts in a strict order

34f3e5e

Previously, NeoFS contracts deployed in free order. In order to avoid potential dependency or stability issues, it's worth to make deployment in a fixed and clearly defined sequence. Signed-off-by: Leonard Lyubich <[email protected]>

sidechain/deploy: Distribute all available NEO between Alphabet contr…

b579092

…acts Make Sidechain deployment procedure to evenly distribute all available NEO tokens between deployed NeoFS Alphabet contracts. Signed-off-by: Leonard Lyubich <[email protected]>

cthulhu-rider force-pushed the feature/deploy-sys-contracts branch from ac4bf9d to 19fdf98 Compare November 10, 2023 09:20

cthulhu-rider added 6 commits November 10, 2023 11:09

sidechain/deploy: Fix Notary role designation for single node

b18bf35

Despite the fact that the committee consists of one member, the transaction must be witnessed by a multi-sig 1:1 account. Signed-off-by: Leonard Lyubich <[email protected]>

sidechain/deploy: Do not init reused actors multiple times

54f7d66

Simple local and committee multi-sig notary actors are used in all `syncNeoFSContract` calls, so it's worth to create them once and share. Signed-off-by: Leonard Lyubich <[email protected]>

sidechain/deploy: Drop unused utilities working with contract versions

073754c

Signed-off-by: Leonard Lyubich <[email protected]>

cthulhu-rider force-pushed the feature/deploy-sys-contracts branch from 19fdf98 to 3dad944 Compare November 10, 2023 10:09

roman-khimov approved these changes Nov 13, 2023

View reviewed changes

roman-khimov merged commit 78289be into nspcc-dev:master Nov 13, 2023
6 of 8 checks passed

roman-khimov mentioned this pull request Nov 29, 2023

Drop network_settings config #2660

Closed


		l.Error("could not read on-chain state of the contract by NNS domain name, trying by pre-calculated address...")

		preCalculatedAddr := state.CreateContractHash(prm.localAcc.ScriptHash(), prm.localNEF.Checksum, prm.localManifest.Name)


		l.Info("sending new transaction registering domain in the NNS...")

		txID, vub, err := localActor.SendCall(prm.nnsContract, methodNNSRegister,

Deploy/update NeoFS contracts automatically within Sidechain deployment procedure #2444

Deploy/update NeoFS contracts automatically within Sidechain deployment procedure #2444

Conversation

cthulhu-rider commented Jul 18, 2023 • edited Loading

codecov bot commented Jul 18, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carpawell Sep 15, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cthulhu-rider commented Oct 23, 2023

cthulhu-rider commented Nov 10, 2023

cthulhu-rider commented Jul 18, 2023 •

edited

Loading

codecov bot commented Jul 18, 2023 •

edited

Loading

carpawell Sep 15, 2023 •

edited

Loading