-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable aws ec2 metadata #2445
Disable aws ec2 metadata #2445
Conversation
Fixed bug nspcc-dev/neofs-s3-gw#798 This bug is only reproducible on ubuntu-latest in github actions. This is a bug specifically of github acions, not the neofs-s3-gw: actions/runner-images#2791 aws/aws-cli#5623 Signed-off-by: Oleg Kulachenko <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2445 +/- ##
==========================================
- Coverage 29.66% 29.48% -0.18%
==========================================
Files 399 399
Lines 29970 30268 +298
==========================================
+ Hits 8892 8926 +34
- Misses 20340 20601 +261
- Partials 738 741 +3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered setting a region like someone fixed it?
I'd like to have more specific description here, what exactly is the relationship between this var and tests. It also looks like this better be fixed in testcases, if there is anything influencing the result it should be controlled there. |
Yes, but this is a test environment configuration bug. It's not even a bug, it's a configuration requirement. |
|
Cause their environment is outdated now OR the "bug" will never come to them?
I briefly read the original issue description and I think that it is more about the way |
@roman-khimov @carpawell , I agree with you, the fix is better done in the https://github.com/nspcc-dev/neofs-testcases repository. |
Fixed bug nspcc-dev/neofs-s3-gw#798 This bug is only reproducible on ubuntu-latest in github actions. This is a bug specifically of github acions, not the neofs-s3-gw: actions/runner-images#2791 aws/aws-cli#5623