Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable aws ec2 metadata #2445

Closed
wants to merge 1 commit into from
Closed

Conversation

vvarg229
Copy link
Contributor

Fixed bug nspcc-dev/neofs-s3-gw#798 This bug is only reproducible on ubuntu-latest in github actions. This is a bug specifically of github acions, not the neofs-s3-gw: actions/runner-images#2791 aws/aws-cli#5623

Fixed bug nspcc-dev/neofs-s3-gw#798
This bug is only reproducible on ubuntu-latest in github actions.
This is a bug specifically of github acions, not the neofs-s3-gw:
actions/runner-images#2791
aws/aws-cli#5623

Signed-off-by: Oleg Kulachenko <[email protected]>
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #2445 (034039a) into master (c408b57) will decrease coverage by 0.18%.
The diff coverage is 6.98%.

❗ Current head 034039a differs from pull request most recent head 4201d47. Consider uploading reports for the commit 4201d47 to get more accurate results

@@            Coverage Diff             @@
##           master    #2445      +/-   ##
==========================================
- Coverage   29.66%   29.48%   -0.18%     
==========================================
  Files         399      399              
  Lines       29970    30268     +298     
==========================================
+ Hits         8892     8926      +34     
- Misses      20340    20601     +261     
- Partials      738      741       +3     
Impacted Files Coverage Δ
cmd/neofs-node/container.go 9.67% <0.00%> (+0.05%) ⬆️
cmd/neofs-node/object.go 0.00% <0.00%> (ø)
pkg/morph/deploy/deploy.go 0.00% <0.00%> (ø)
pkg/morph/deploy/group.go 11.90% <0.00%> (+0.27%) ⬆️
pkg/morph/deploy/nns.go 0.00% <0.00%> (ø)
pkg/morph/deploy/notary.go 0.00% <0.00%> (ø)
pkg/services/object/acl/acl.go 29.26% <0.00%> (ø)
pkg/services/policer/check.go 11.11% <0.00%> (ø)
pkg/services/tree/signature.go 68.99% <0.00%> (ø)
pkg/morph/deploy/util.go 23.64% <42.68%> (+23.64%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered setting a region like someone fixed it?

@roman-khimov
Copy link
Member

I'd like to have more specific description here, what exactly is the relationship between this var and tests. It also looks like this better be fixed in testcases, if there is anything influencing the result it should be controlled there.

@vvarg229
Copy link
Contributor Author

I'd like to have more specific description here, what exactly is the relationship between this var and tests. It also looks like this better be fixed in testcases, if there is anything influencing the result it should be controlled there.

Yes, but this is a test environment configuration bug. It's not even a bug, it's a configuration requirement.
On other runners (local laptop, server inside infrastructure, etc) this bug is not present.
So I think the correct way to approach this would be to fix it on the GitHub runner side.

@vvarg229
Copy link
Contributor Author

Have you considered setting a region like someone fixed it?

#2445 (comment)

@carpawell
Copy link
Member

On other runners (local laptop, server inside infrastructure, etc) this bug is not present.

Cause their environment is outdated now OR the "bug" will never come to them?

it's a configuration requirement

I briefly read the original issue description and I think that it is more about the way aws CLI is called not the way neofs-node is tested. That repo does not call aws at all, right? The neofs-testcases does. That is why i asked about the "call step" solution.

@vvarg229
Copy link
Contributor Author

@roman-khimov @carpawell , I agree with you, the fix is better done in the https://github.com/nspcc-dev/neofs-testcases repository.
I'm closing this PR.

@vvarg229 vvarg229 closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants