fix/Container estimations contract call #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not reputation metrics, it was a mistake. The same as nspcc-dev#1537. Signed-off-by: Pavel Karpy <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2467 +/- ##
=======================================
Coverage 29.48% 29.48%
=======================================
Files 399 399
Lines 30430 30430
=======================================
Hits 8971 8971
Misses 20715 20715
Partials 744 744
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
carpawell
force-pushed
the
fix/container-estimations
branch
from
21fa739
to
8875735
Compare
roman-khimov
reviewed
Aug 2, 2023
carpawell
force-pushed
the
fix/container-estimations
branch
from
8875735
to
40defc5
Compare
roman-khimov
reviewed
Aug 3, 2023
carpawell
force-pushed
the
fix/container-estimations
branch
from
40defc5
to
e6fa650
Compare
Some contract methods still require regular (non-notary) calls. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/container-estimations
branch
from
e6fa650
to
9eb49fd
Compare
roman-khimov
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #1506. Does not fix (of does fix, not sure yet but that is the first time I can see at least one metric in the contract locally).