Handle client errors according to NeoFS SDK RC-9 #2469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently used SDK revision changed/improved docs and UX of error handling. Storage node missed these changes on SDK upgrade, so we have to adjust to them. Use `errors.Is` when exact error structure is not needed. Actualize docs of errors returned by internal client. Fixes #2465. Signed-off-by: Leonard Lyubich <[email protected]>
We don't have to use `errors.As` to just check error type now, `errors.Is` is more appropriate for this. Signed-off-by: Leonard Lyubich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test reports cannot be posted in NeoFS from PR from the forked repo, and source branch cannot be changed