-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/Do not store estimations forever #2472
Fix/Do not store estimations forever #2472
Conversation
bc7c6e1
to
7a5f8ef
Compare
Codecov Report
@@ Coverage Diff @@
## master #2472 +/- ##
==========================================
+ Coverage 29.24% 29.25% +0.01%
==========================================
Files 399 399
Lines 30368 30387 +19
==========================================
+ Hits 8881 8891 +10
- Misses 20751 20760 +9
Partials 736 736
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM, minor stuff and linter
7a5f8ef
to
9df591a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if drop Prm
, then change all callers
Yeah, can't be compiled at the moment. |
9df591a
to
bae2e74
Compare
Underpush. Fixed. |
bae2e74
to
20a00ef
Compare
Signed-off-by: Pavel Karpy <[email protected]>
For debug purposes. May be dropped in the future. Signed-off-by: Pavel Karpy <[email protected]>
For debug purposes. May be dropped in the future. Signed-off-by: Pavel Karpy <[email protected]>
Not needed for a util with such a limited usage. Signed-off-by: Pavel Karpy <[email protected]>
20a00ef
to
95eae6d
Compare
|
Also, improves estimations debug logs.