rm/Drop placement code copy #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2478 +/- ##
==========================================
+ Coverage 29.26% 29.29% +0.03%
==========================================
Files 399 399
Lines 30390 30346 -44
==========================================
- Hits 8893 8891 -2
+ Misses 20761 20719 -42
Partials 736 736
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Waits for #2470. |
roman-khimov
approved these changes
Aug 8, 2023
rdy |
carpawell
force-pushed
the
rm/drop-custom-placement-code
branch
from
ee1ce55
to
f33a730
Compare
cthulhu-rider
approved these changes
Aug 10, 2023
|
CHANGELOG! |
You mean changed placement? Copy-paste/removal of the SDK's code is not needed to be changelogged, IMO. |
|
Yeah, I'm not sure it affects users in any way, but it's a change and formally even a protocol-level one (old nodes compute these things differently). |
carpawell
force-pushed
the
rm/drop-custom-placement-code
branch
from
f33a730
to
34ee6fb
Compare
It was added only due to a temporary SDK's interface problem. SDK RC10 has solved it. NOTE: generally, the placement for container estimations changed with this commit: another pivot is used. We do this change cause SDK used to have a bug related to the placement func and placement changes are expected after RC9 -> RC10 update anyway. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
rm/drop-custom-placement-code
branch
from
34ee6fb
to
59a8b5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was added only due to a temporary SDK's interface problem. SDK RC10 has solved it.
NOTE: generally, the placement for container estimations changed with this commit: another pivot is used. We do this change cause SDK used to have a bug related to the placement func and placement changes are expected after RC9 -> RC10 update anyway.