cli: Add ACL details to --basic-acl flag #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2481 +/- ##
=======================================
Coverage 29.24% 29.24%
=======================================
Files 399 399
Lines 30368 30368
=======================================
Hits 8881 8881
Misses 20751 20751
Partials 736 736 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@AliceInHunterland congrats with ur 1st PR 🌵 lets resolve DCO remark and also pay attention to @roman-khimov comment #2356 (comment) |
AliceInHunterland
force-pushed
the
feature/2356-add-acl-details
branch
2 times, most recently
from
f9a90bc
to
acab21a
Compare
AliceInHunterland
changed the title
AliceInHunterland
force-pushed
the
feature/2356-add-acl-details
branch
from
1a2274b
to
347b4d1
Compare
cthulhu-rider
approved these changes
Aug 9, 2023
roman-khimov
reviewed
Aug 9, 2023
AliceInHunterland
force-pushed
the
feature/2356-add-acl-details
branch
from
a3aa133
to
753483a
Compare
Closes #2356. Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
feature/2356-add-acl-details
branch
from
753483a
to
3966600
Compare
Refs #2356. Signed-off-by: Ekaterina Pavlova <[email protected]>
roman-khimov
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more info to --basic-acl flag. Closes [#2356]