Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/Announce version via the attributes #2484

Conversation

carpawell
Copy link
Member

It is done automatically but can be overwritten if Version attribute is provided via the application configuration.
Closes #2455.

It is done automatically but can be overwritten if `Version` attribute is
provided via the application configuration.
Closes nspcc-dev#2455.

Signed-off-by: Pavel Karpy <[email protected]>
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #2484 (cef9181) into master (9f0077e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head cef9181 differs from pull request most recent head 26db709. Consider uploading reports for the commit 26db709 to get more accurate results

@@            Coverage Diff             @@
##           master    #2484      +/-   ##
==========================================
- Coverage   29.25%   29.24%   -0.01%     
==========================================
  Files         399      399              
  Lines       30368    30371       +3     
==========================================
- Hits         8883     8881       -2     
- Misses      20749    20754       +5     
  Partials      736      736              
Files Changed Coverage Δ
cmd/neofs-node/config.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@cthulhu-rider cthulhu-rider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cthulhu-rider cthulhu-rider merged commit 4e0eb31 into nspcc-dev:master Aug 10, 2023
7 of 8 checks passed
@carpawell carpawell deleted the feat/add-app-version-attribute-automatically branch August 10, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Announce node version in SN attributes automatically
3 participants