cli: set-eacl update #2490
Merged
cli: set-eacl update #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
changed the title
AliceInHunterland
changed the title
|
You can add multiple commits, each solving a particular part of the problem. |
AliceInHunterland
force-pushed
the
feature/2436-cli-set-eacl-check
branch
from
d4979b3
to
dffe16c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2490 +/- ##
=======================================
Coverage 29.29% 29.29%
=======================================
Files 399 399
Lines 30346 30346
=======================================
Hits 8891 8891
Misses 20719 20719
Partials 736 736 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AliceInHunterland
force-pushed
the
feature/2436-cli-set-eacl-check
branch
2 times, most recently
from
b37ff3b
to
3f01823
Compare
AliceInHunterland
force-pushed
the
feature/2436-cli-set-eacl-check
branch
4 times, most recently
from
9c437c9
to
a2add5f
Compare
AliceInHunterland
requested review from
carpawell and
cthulhu-rider
as code owners
AliceInHunterland
force-pushed
the
feature/2436-cli-set-eacl-check
branch
3 times, most recently
from
974067a
to
883dde9
Compare
The eACL table can only be set by the container owner or his authorized representative. Similar to `container delete`, it makes sense to add an ownership check to `container set-eacl`. Precede the ACL extensibility check with an owner check: if the `--no-precheck` flag is set, then the caller must be the owner of the container or provide a session token signed by them. Refs #2436. Signed-off-by: Ekaterina Pavlova <[email protected]>
Deprecate no-precheck flag which is functionally the same as force(skips verification). Closes #2436. Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
feature/2436-cli-set-eacl-check
branch
from
883dde9
to
cbac4d3
Compare
roman-khimov
approved these changes
Aug 11, 2023
cthulhu-rider
approved these changes
Aug 11, 2023
AliceInHunterland
added a commit
that referenced
this pull request
Oct 2, 2023
Remove the "no-precheck" flag, which is equivalent to "force" (skips verification) and has been deprecated since #2490. Closes: #2496. Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
added a commit
that referenced
this pull request
Oct 2, 2023
Remove the "no-precheck" flag, which is equivalent to "force" (skips verification) and has been deprecated since #2490. Closes: #2496. Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
added a commit
that referenced
this pull request
Oct 2, 2023
Remove the "no-precheck" flag, which is equivalent to "force" (skips verification) and has been deprecated since #2490. Closes: #2496. Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
added a commit
that referenced
this pull request
Oct 2, 2023
Remove the "no-precheck" flag, which is equivalent to "force" (skips verification) and has been deprecated since #2490. Closes: #2496. Signed-off-by: Ekaterina Pavlova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
force flag added, no-precheck deprecated, ownership check added
Refs #2436.