Add Peapod to NeoFS Lens #2514
Merged
Add Peapod to NeoFS Lens #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cthulhu-rider
commented
Aug 16, 2023
•
cthulhu-rider
commented
- closes Add peapod into neofs-lens #2507
Previously, `Peapod` provided `Iterate` method implementing `common.Storage` interface for data traversal. This method allows to iterate over keys (object addresses) only, but in suboptimal way: data is decoded and ignored at the same time. Some other components like Blobovnicza provide dedicated key-only iterator, so it's worth to support this feature in Peapod, too. Add `IterateAddresses` method with simple signature. Refs #2507. Signed-off-by: Leonard Lyubich <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2514 +/- ##
==========================================
+ Coverage 29.68% 29.69% +0.01%
==========================================
Files 404 404
Lines 30697 30711 +14
==========================================
+ Hits 9111 9119 +8
- Misses 20820 20824 +4
- Partials 766 768 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cthulhu-rider
force-pushed
the
feature/2507-lens-peapod
branch
from
6040a56
to
2e47340
Compare
roman-khimov
approved these changes
Aug 16, 2023
carpawell
approved these changes
Aug 16, 2023
carpawell
reviewed
Aug 16, 2023
Recently introduced storage component named Peapod is a good candidate to be inspected by NeoFS Lens app. Add `peapod` command with `inspect` and `list` sub-commands similar to `blobovnicza` and `write-cache` commands. Closes #2507. Signed-off-by: Leonard Lyubich <[email protected]>
It's easy to encounter runtime panic due to non-obvious Peapod interface: some extra methods must be called before data interface usage (see NeoFS Lens implementation for example). Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
feature/2507-lens-peapod
branch
from
2e47340
to
6d802f4
Compare
carpawell
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.