cmd: fix copyLocks issue #2586
Merged
cmd: fix copyLocks issue #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copylocks: resetCaches passes lock by value: github.com/nspcc-dev/neofs-node/cmd/neofs-node.shared contains sync/atomic.Bool contains sync/atomic.noCopy (govet) Introduced by #2485. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
carpawell
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Dont we want to run the linter against the whole project?
It would have prevented that PR.
|
Of course we want to. IIRC it was discussed already some time ago. |
Sometimes touching one line of code breaks the other and we're 100% clean now. Signed-off-by: Roman Khimov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2586 +/- ##
=======================================
Coverage 29.82% 29.83%
=======================================
Files 406 406
Lines 31019 31019
=======================================
+ Hits 9252 9255 +3
+ Misses 20956 20954 -2
+ Partials 811 810 -1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
carpawell
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copylocks: resetCaches passes lock by value: github.com/nspcc-dev/neofs-node/cmd/neofs-node.shared contains sync/atomic.Bool contains sync/atomic.noCopy (govet)
Introduced by #2485.