Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Upgrade to the latest github.com/nspcc-dev/neofs-sdk-go revision #2787

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

cthulhu-rider
Copy link
Contributor

dont burden subsequent updates with fixing the problem

@roman-khimov
Copy link
Member

Tests have failed.

@cthulhu-rider
Copy link
Contributor Author

primary hypothesis: REST gateway can corrupt sealed tokens. I need some time to explore it

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 22.03%. Comparing base (f4812fa) to head (af4d471).
Report is 10 commits behind head on master.

❗ Current head af4d471 differs from pull request most recent head 25b2988. Consider uploading reports for the commit 25b2988 to get more accurate results

Files Patch % Lines
cmd/neofs-cli/modules/util/sign_bearer.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2787      +/-   ##
==========================================
+ Coverage   22.02%   22.03%   +0.01%     
==========================================
  Files         789      789              
  Lines       47228    47245      +17     
==========================================
+ Hits        10401    10412      +11     
- Misses      35934    35940       +6     
  Partials      893      893              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

It brings breaking (for good) changes which need to be adapted asap. New
SDK also includes fix of numeric access rules' processing.

Fixes #2785.

Signed-off-by: Leonard Lyubich <[email protected]>
@cthulhu-rider
Copy link
Contributor Author

@roman-khimov roman-khimov merged commit 0d6d585 into master Apr 1, 2024
24 of 29 checks passed
@roman-khimov roman-khimov deleted the upgrade/sdk branch April 1, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants