Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cli delete several objects #2875

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

carpawell
Copy link
Member

No description provided.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 23.69%. Comparing base (0e4f7c9) to head (7ca3566).

Files Patch % Lines
cmd/neofs-cli/modules/object/delete.go 0.00% 28 Missing ⚠️
cmd/neofs-cli/modules/object/util.go 0.00% 7 Missing ⚠️
cmd/neofs-cli/modules/object/lock.go 0.00% 1 Missing ⚠️
cmd/neofs-cli/modules/object/put.go 0.00% 1 Missing ⚠️
cmd/neofs-cli/modules/storagegroup/delete.go 0.00% 1 Missing ⚠️
cmd/neofs-cli/modules/storagegroup/put.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2875      +/-   ##
==========================================
- Coverage   23.69%   23.69%   -0.01%     
==========================================
  Files         770      770              
  Lines       44580    44583       +3     
==========================================
  Hits        10565    10565              
- Misses      33161    33164       +3     
  Partials      854      854              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carpawell carpawell force-pushed the feat/cli-delete-several-objects branch 2 times, most recently from 7f92d60 to 20f3701 Compare June 26, 2024 01:59
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC old commands (--oid XYZ) still work the same way with the same CLI output?

cmd/neofs-cli/modules/object/util.go Show resolved Hide resolved
cmd/neofs-cli/modules/object/delete.go Show resolved Hide resolved
@carpawell
Copy link
Member Author

IIUC old commands (--oid XYZ) still work the same way with the same CLI output?

Yes (almost, it now prints an object ID that has been removed).

@carpawell carpawell force-pushed the feat/cli-delete-several-objects branch from 20f3701 to bcf589c Compare June 26, 2024 21:40
@carpawell carpawell force-pushed the feat/cli-delete-several-objects branch 2 times, most recently from c960966 to 729ae50 Compare June 27, 2024 17:37
cmd/neofs-cli/modules/object/util.go Outdated Show resolved Hide resolved
cmd/neofs-cli/modules/object/delete.go Outdated Show resolved Hide resolved
cmd/neofs-cli/modules/object/delete.go Show resolved Hide resolved
cmd/neofs-cli/modules/object/delete.go Show resolved Hide resolved
cmd/neofs-cli/modules/object/delete.go Show resolved Hide resolved
cmd/neofs-cli/modules/object/delete.go Outdated Show resolved Hide resolved
cmd/neofs-cli/modules/object/delete.go Outdated Show resolved Hide resolved
@cthulhu-rider
Copy link
Contributor

good overall

Child objects are not used in tombstones since
e97444a.

Signed-off-by: Pavel Karpy <[email protected]>
@carpawell carpawell force-pushed the feat/cli-delete-several-objects branch from 729ae50 to 7ca3566 Compare June 28, 2024 14:56
@cthulhu-rider cthulhu-rider merged commit ecc0314 into master Jul 1, 2024
20 of 22 checks passed
@cthulhu-rider cthulhu-rider deleted the feat/cli-delete-several-objects branch July 1, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants