Check the account alongside the public key #2883
Conversation
smallhive
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
smallhive
force-pushed
the
account-based-eacl-targets
branch
from
72f5541
to
70ca640
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2883 +/- ##
==========================================
+ Coverage 23.53% 23.54% +0.01%
==========================================
Files 776 776
Lines 45302 45273 -29
==========================================
- Hits 10660 10658 -2
+ Misses 33792 33769 -23
+ Partials 850 846 -4 ☔ View full report in Codecov by Sentry. |
|
smallhive
force-pushed
the
account-based-eacl-targets
branch
from
70ca640
to
68a2ab1
Compare
smallhive
force-pushed
the
account-based-eacl-targets
branch
from
68a2ab1
to
4dbc22d
Compare
| ) | ||
| WithEACLTable(&table) | ||
|
|
||
| if sa := reqInfo.SenderAccount(); sa != nil && !sa.IsZero() { |
There was a problem hiding this comment.
can it ever be nil? seems like we can get rid of a pointer
There was a problem hiding this comment.
missing sender is a strange thing to me, an error should appear earlier, no?
There was a problem hiding this comment.
Before this change, the account wasn't represented at all. It was only key []byte. According to the code, at this point, it can't be nil, but in the future - nobody knows.
Do you suggest removing the pointer?
There was a problem hiding this comment.
Can you wrap some too long lines in the commit body? We have some rules about it: https://github.com/nspcc-dev/.github/blob/master/git.md
Otherwise, ok.
| @@ -18,7 +18,7 @@ require ( | |||
| github.com/nspcc-dev/neo-go v0.106.3 | |||
| github.com/nspcc-dev/neofs-api-go/v2 v2.14.1-0.20240305074711-35bc78d84dc4 | |||
| github.com/nspcc-dev/neofs-contract v0.20.0 | |||
| github.com/nspcc-dev/neofs-sdk-go v1.0.0-rc.12 | |||
| github.com/nspcc-dev/neofs-sdk-go v1.0.0-rc.12.0.20240807160341-3528eb5bb1cc | |||
There was a problem hiding this comment.
oh, i really dont like we are updating SDK at this moment (it is being changed a lot now) in one of the pre-release PR, but if we need it to be done, ok
| ) | ||
| WithEACLTable(&table) | ||
|
|
||
| if sa := reqInfo.SenderAccount(); sa != nil && !sa.IsZero() { |
There was a problem hiding this comment.
missing sender is a strange thing to me, an error should appear earlier, no?
Signed-off-by: Evgenii Baidakov <[email protected]>
Linter message: staticcheck SA1019: eaclSDK.NewTableFromV2 is deprecated: BUG: container ID length is not checked. Use [Table.ReadFromV2] instead. Signed-off-by: Evgenii Baidakov <[email protected]>
The object can't be a slice with only zeros. Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
account-based-eacl-targets
branch
from
4dbc22d
to
f8ccf59
Compare
Refs nspcc-dev/neofs-api#278