Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neofs-lens/storage: add a sanity storage check #2884

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

carpawell
Copy link
Member

@carpawell carpawell commented Jul 5, 2024

Checks can be extended later (or in this PR if suggestions appear).

@carpawell carpawell self-assigned this Jul 5, 2024
@carpawell
Copy link
Member Author

Will do some tests run on testnet.

@carpawell carpawell force-pushed the feat/add-object-sanity-checker branch from adb8b06 to e08bf4a Compare July 5, 2024 17:30
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 125 lines in your changes missing coverage. Please review.

Project coverage is 23.67%. Comparing base (e6eeda1) to head (a32f52f).
Report is 6 commits behind head on master.

Files Patch % Lines
cmd/neofs-lens/internal/storage/sanity.go 0.00% 124 Missing ⚠️
cmd/neofs-lens/internal/storage/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2884      +/-   ##
==========================================
- Coverage   23.74%   23.67%   -0.07%     
==========================================
  Files         774      775       +1     
  Lines       44801    44908     +107     
==========================================
- Hits        10636    10634       -2     
- Misses      33311    33419     +108     
- Partials      854      855       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carpawell carpawell force-pushed the feat/add-object-sanity-checker branch 2 times, most recently from 135cef2 to e4d3dc8 Compare July 5, 2024 17:33
@carpawell carpawell marked this pull request as ready for review July 5, 2024 17:33
Copy link
Contributor

@cthulhu-rider cthulhu-rider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in total

cmd/neofs-lens/internal/storage/sanity.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/storage/sanity.go Show resolved Hide resolved
cmd/neofs-lens/internal/storage/sanity.go Show resolved Hide resolved
cmd/neofs-lens/internal/storage/sanity.go Show resolved Hide resolved
cmd/neofs-lens/internal/storage/sanity.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/storage/sanity.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/storage/sanity.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/storage/sanity.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/storage/sanity.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/storage/sanity.go Outdated Show resolved Hide resolved
@carpawell carpawell force-pushed the feat/add-object-sanity-checker branch from 03b45a2 to a4c5aee Compare July 10, 2024 20:04
@cthulhu-rider cthulhu-rider merged commit 4f90cc2 into master Jul 10, 2024
18 of 22 checks passed
@cthulhu-rider cthulhu-rider deleted the feat/add-object-sanity-checker branch July 10, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants