Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade .golangci.yml config #2893

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Upgrade .golangci.yml config #2893

merged 2 commits into from
Jul 11, 2024

Commits on Jul 11, 2024

  1. lint: Refresh deprecated config 

    This fixes
```
$ golangci-lint --version
golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z
$ golangci-lint run ./...
WARN [config_reader] The configuration option `output.format` is deprecated, please use `output.formats`
```

The configuration file is updated according to
https://golangci-lint.run/usage/configuration/.

Signed-off-by: Leonard Lyubich <[email protected]>
    @cthulhu-rider
    cthulhu-rider committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    e1d7877 View commit details
    Browse the repository at this point in the history

  2. lint: Drop no-op govet config 

    According to https://golangci-lint.run/usage/linters/#govet,
`check-shadowing` no longer exists. Now it should be
```yaml
govet:
  disable: [shadow]
```
but `shadow` is disabled by default. Thus, whole `govet` section is not
needed anymore.

```
$ golangci-lint --version
golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z
```

Signed-off-by: Leonard Lyubich <[email protected]>
    @cthulhu-rider
    cthulhu-rider committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    cadd6b1 View commit details
    Browse the repository at this point in the history