fix/allow "1b" config values for memory amount #2899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
force-pushed
the
fix/configuration-values-in-bytes
branch
from
0a2957a
to
3e22688
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2899 +/- ##
=======================================
Coverage 23.73% 23.73%
=======================================
Files 775 775
Lines 44933 44933
=======================================
Hits 10664 10664
Misses 33417 33417
Partials 852 852 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Jul 25, 2024
cthulhu-rider
approved these changes
Jul 26, 2024
carpawell
force-pushed
the
fix/configuration-values-in-bytes
branch
2 times, most recently
from
0503763
to
f6170cd
Compare
carpawell
force-pushed
the
fix/configuration-values-in-bytes
branch
from
f6170cd
to
d838b06
Compare
carpawell
changed the title
carpawell
force-pushed
the
fix/configuration-values-in-bytes
branch
from
d838b06
to
856bfd6
Compare
It was not used in practice before, so no issues were opened, or tests were written, but it still looks like a valid configuration value. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/configuration-values-in-bytes
branch
from
856bfd6
to
92a9abe
Compare
cthulhu-rider
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not used in practice before, so no issues were opened, or tests were written, but it still looks like a valid configuration value.