node/placement: use predefined error for empty netmap #2916
Conversation
|
Well, we need to fix deprecation warnings anyway, otherwise linter would become useless for some time. |
|
Oh, changing SDK significantly for months... Let this PR be a reminder, I do not expect it to adopt SDK. |
|
Current set of changes is rather small, these are easy to fix. |
SDK somehow generates a random checksum (with a random type too) every time now, so the old tests should be ready for it (do not use test SDK package in fact). Closes #2917, and improves test granularity a little. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/dirty-error-comparasing
branch
2 times, most recently
from
5bed985
to
f3cb1ea
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2916 +/- ##
==========================================
- Coverage 23.51% 23.50% -0.01%
==========================================
Files 776 776
Lines 45318 45326 +8
==========================================
Hits 10656 10656
- Misses 33815 33823 +8
Partials 847 847 ☔ View full report in Codecov by Sentry. |
|
Ok, fixed. But I was surprised how inconvenient is now SDK for eacl tables constructing in the apps like our CLI. |
carpawell
force-pushed
the
fix/dirty-error-comparasing
branch
from
f3cb1ea
to
a775085
Compare
nspcc-dev/neofs-sdk-go#615 was merged, and it is now possible to use the error. Commit includes SDK update _without_ new API adoption. Signed-off-by: Pavel Karpy <[email protected]>
Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/dirty-error-comparasing
branch
from
a775085
to
5eeff3f
Compare
| validateAndFixEACLVersion(table) | ||
| PrintVerbose(cmd, "Parsed JSON encoded EACL table") | ||
| return table | ||
| } | ||
|
|
||
| if err = table.Unmarshal(data); err == nil { | ||
| table, err = eacl.Unmarshal(data) |
There was a problem hiding this comment.
what was wrong with previous code?
There was a problem hiding this comment.
Table should be created using one of the constructors.
updated docs say so
There was a problem hiding this comment.
u already have an instance
carpawell
force-pushed
the
fix/dirty-error-comparasing
branch
from
5eeff3f
to
388d92a
Compare
carpawell
force-pushed
the
fix/dirty-error-comparasing
branch
from
388d92a
to
6ad2ad6
Compare
nspcc-dev/neofs-sdk-go#615 was merged, and it is now possible to use the error. Commit includes SDK update without new API adoption.