Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upd/go 1.22 #2927

Merged
merged 8 commits into from
Sep 5, 2024
Merged

Upd/go 1.22 #2927

merged 8 commits into from
Sep 5, 2024

Conversation

carpawell
Copy link
Member

No description provided.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 37.03704% with 17 lines in your changes missing coverage. Please review.

Project coverage is 23.88%. Comparing base (de5a12c) to head (b44048e).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
pkg/services/control/server/evacuate.go 0.00% 3 Missing ⚠️
cmd/neofs-adm/internal/modules/morph/initialize.go 0.00% 2 Missing ⚠️
pkg/services/audit/auditor/pdp.go 0.00% 2 Missing ⚠️
...md/neofs-adm/internal/modules/morph/dump_hashes.go 0.00% 1 Missing ⚠️
cmd/neofs-cli/modules/util/acl.go 0.00% 1 Missing ⚠️
pkg/innerring/contracts.go 0.00% 1 Missing ⚠️
...ct_storage/blobstor/fstree/fstree_write_generic.go 0.00% 1 Missing ⚠️
pkg/local_object_storage/writecache/storage.go 0.00% 1 Missing ⚠️
pkg/morph/client/constructor.go 0.00% 1 Missing ⚠️
pkg/morph/client/multi.go 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2927      +/-   ##
==========================================
- Coverage   23.89%   23.88%   -0.02%     
==========================================
  Files         775      775              
  Lines       45632    45610      -22     
==========================================
- Hits        10904    10892      -12     
+ Misses      33871    33861      -10     
  Partials      857      857              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/neofs-adm/internal/modules/morph/initialize.go Outdated Show resolved Hide resolved
cmd/neofs-node/reputation/ticker/fixed_test.go Outdated Show resolved Hide resolved
pkg/morph/event/notary_preparator_test.go Outdated Show resolved Hide resolved
pkg/services/control/server/evacuate.go Outdated Show resolved Hide resolved
pkg/morph/event/notary_preparator.go Outdated Show resolved Hide resolved
@roman-khimov
Copy link
Member

And please update .docker/*

@roman-khimov
Copy link
Member

And README

Go devs decided that it is a unique copy every iteration since go 1.22.

Signed-off-by: Pavel Karpy <[email protected]>
@carpawell
Copy link
Member Author

And README

Fixed, but i would prefer "not older than go.mod's version of Go".

@roman-khimov roman-khimov merged commit d214b0c into master Sep 5, 2024
20 of 21 checks passed
@roman-khimov roman-khimov deleted the upd/go-1.22 branch September 5, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants