Org-wide linter

.github/workflows/go.yml

@@ -69,14 +69,5 @@ jobs:
         run: go test -race ./...
 
   lint:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-go@v5
-        with:
-          go-version-file: 'go.mod'
-      - name: golangci-lint
-        uses: golangci/golangci-lint-action@v4
-        with:
-          version: latest
-          args: --timeout=5m
+    name: Lint
+    uses: nspcc-dev/.github/.github/workflows/go-linter.yml@master

.gitignore

@@ -28,6 +28,7 @@ testfile
 
 # misc
 .neofs-cli.yml
+.golangci.yml
 
 # debhelpers
 **/.debhelper

CHANGELOG.md

@@ -12,6 +12,7 @@ Changelog for NeoFS Node
 
 ### Changed
 - `ObjectService`'s `Put` RPC handler caches up to 10K lists of per-object sorted container nodes (#2901)
+- Use org-wide linter (#2943)
 
 ### Removed
 

Makefile

@@ -128,8 +128,11 @@ test:
 	@echo "⇒ Running go test"
 	@go test ./...
 
+.golangci.yml:
+	wget -O $@ https://github.com/nspcc-dev/.github/raw/master/.golangci.yml
+
 # Run linters
-lint:
+lint: .golangci.yml
 	@golangci-lint --timeout=5m run
 
 # Run linters in Docker

cmd/neofs-adm/internal/modules/config/config_test.go

@@ -35,11 +35,11 @@ func TestGenerateConfigExample(t *testing.T) {
 	require.Equal(t, 100000000, v.GetInt("network.fee.withdraw"))
 
 	var i int
-	for i = 0; i < n; i++ {
+	for i = range n {
 		key := "credentials." + glagolitsa.LetterByIndex(i)
 		require.Equal(t, "password", v.GetString(key))
 	}
 
-	key := "credentials." + glagolitsa.LetterByIndex(i)
+	key := "credentials." + glagolitsa.LetterByIndex(i+1)
 	require.Equal(t, "", v.GetString(key))
 }

cmd/neofs-adm/internal/modules/morph/generate_test.go

@@ -55,13 +55,13 @@ func TestGenerateAlphabet(t *testing.T) {
 	buf.Reset()
 	v.Set(alphabetWalletsFlag, walletDir)
 	require.NoError(t, generateAlphabetCmd.Flags().Set(alphabetSizeFlag, strconv.FormatUint(size, 10)))
-	for i := uint64(0); i < size; i++ {
+	for i := range uint64(size) {
 		buf.WriteString(strconv.FormatUint(i, 10) + "\r")
 	}
 
 	require.NoError(t, generateAlphabetCreds(generateAlphabetCmd, nil))
 
-	for i := uint64(0); i < size; i++ {
+	for i := range uint64(size) {
 		p := filepath.Join(walletDir, glagolitsa.LetterByIndex(int(i))+".json")
 		w, err := wallet.NewWalletFromFile(p)
 		require.NoError(t, err, "wallet doesn't exist")

cmd/neofs-adm/internal/modules/morph/local_client.go

@@ -212,13 +212,13 @@
 			continue
 		}
 
-		fee, sizeDelta := fee.Calculate(ef, verificationScript)
-		netFee += fee
+		newFee, sizeDelta := fee.Calculate(ef, verificationScript)
+		netFee += newFee
 		size += sizeDelta
 	}
 
-	fee := l.bc.FeePerByte()
-	netFee += int64(size) * fee
+	feePerByte := l.bc.FeePerByte()
+	netFee += int64(size) * feePerByte
 
 	return netFee, nil
 }
@@ -319,7 +319,7 @@
 
 	script, err := b.Script()
 	if err != nil {
-		return nil, fmt.Errorf("BUG: invalid parameters for '%s': %v", method, err)
+		return nil, fmt.Errorf("BUG: invalid parameters for '%s': %w", method, err)
 	}
 
 	return c.InvokeScript(script, signers)

cmd/neofs-adm/internal/modules/morph/notary.go

@@ -31,7 +31,7 @@
 
 	w, err := wallet.NewWalletFromFile(p)
 	if err != nil {
-		return fmt.Errorf("can't open wallet: %v", err)
+		return fmt.Errorf("can't open wallet: %w", err)
 	}
 
 	accHash := w.GetChangeAddress()
@@ -50,12 +50,12 @@
 	prompt := fmt.Sprintf("Enter password for %s >", address.Uint160ToString(accHash))
 	pass, err := input.ReadPassword(prompt)
 	if err != nil {
-		return fmt.Errorf("can't get password: %v", err)
+		return fmt.Errorf("can't get password: %w", err)
 	}
 
 	err = acc.Decrypt(pass, keys.NEP2ScryptParams())
 	if err != nil {
-		return fmt.Errorf("can't unlock account: %v", err)
+		return fmt.Errorf("can't unlock account: %w", err)
 	}
 
 	gasStr, err := cmd.Flags().GetString(refillGasAmountFlag)
@@ -86,7 +86,7 @@
 
 	height, err := c.GetBlockCount()
 	if err != nil {
-		return fmt.Errorf("can't get current height: %v", err)
+		return fmt.Errorf("can't get current height: %w", err)
 	}
 
 	act, err := actor.New(c, []actor.SignerAccount{{

cmd/neofs-adm/internal/modules/morph/verified_domains.go

@@ -120,7 +120,7 @@
 
 	w, err := wallet.NewWalletFromFile(viper.GetString(walletFlag))
 	if err != nil {
-		return fmt.Errorf("decode Neo wallet from file: %v", err)
+		return fmt.Errorf("decode Neo wallet from file: %w", err)
 	}
 
 	var accAddr util.Uint160
@@ -141,12 +141,12 @@
 	prompt := fmt.Sprintf("Enter password for %s >", address.Uint160ToString(accAddr))
 	pass, err := input.ReadPassword(prompt)
 	if err != nil {
-		return fmt.Errorf("failed to read account password: %v", err)
+		return fmt.Errorf("failed to read account password: %w", err)
 	}
 
 	err = acc.Decrypt(pass, keys.NEP2ScryptParams())
 	if err != nil {
-		return fmt.Errorf("failed to unlock the account with password: %v", err)
+		return fmt.Errorf("failed to unlock the account with password: %w", err)
 	}
 
 	n3Client, err := getN3Client(vpr)

cmd/neofs-cli/modules/acl/extended/create_test.go

@@ -12,7 +12,7 @@ func TestParseTable(t *testing.T) {
 	tests := [...]struct {
 		name       string // test name
 		rule       string // input extended ACL rule
-		jsonRecord string // produced record after successfull parsing
+		jsonRecord string // produced record after successful parsing
 	}{
 		{
 			name:       "valid rule with multiple filters",
@@ -68,21 +68,21 @@ func TestParseTable(t *testing.T) {
 		},
 	}
 
-	eaclTable := eacl.NewTable()
+	eaclTable := eacl.ConstructTable(nil)
 
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			err := util.ParseEACLRule(eaclTable, test.rule)
+			err := util.ParseEACLRule(&eaclTable, test.rule)
 			ok := len(test.jsonRecord) > 0
 			require.Equal(t, ok, err == nil, err)
 			if ok {
-				expectedRecord := eacl.NewRecord()
+				expectedRecord := eacl.ConstructRecord(eacl.ActionUnspecified, eacl.OperationUnspecified, nil, eacl.Filter{})
 				err = expectedRecord.UnmarshalJSON([]byte(test.jsonRecord))
 				require.NoError(t, err)
 
 				actualRecord := eaclTable.Records()[len(eaclTable.Records())-1]
 
-				equalRecords(t, expectedRecord, &actualRecord)
+				equalRecords(t, &expectedRecord, &actualRecord)
 			}
 		})
 	}

cmd/neofs-cli/modules/util/acl.go

@@ -83,7 +83,7 @@
 func eaclTargetsToString(ts []eacl.Target) string {
 	b := bytes.NewBuffer(nil)
 	for _, t := range ts {
-		keysExists := len(t.BinaryKeys()) > 0
+		keysExists := len(t.RawSubjects()) > 0
 		switch t.Role() {
 		case eacl.RoleUser:
 			b.WriteString("User")
@@ -107,7 +107,7 @@
 			}
 		}
 
-		for i, pub := range t.BinaryKeys() {
+		for i, pub := range t.RawSubjects() {
 			if i != 0 {
 				b.WriteString("         ")
 			}
@@ -183,7 +183,7 @@
 	for _, ruleStr := range rules {
 		err := ParseEACLRule(table, ruleStr)
 		if err != nil {
-			return fmt.Errorf("can't create extended acl record from rule '%s': %v", ruleStr, err)
+			return fmt.Errorf("can't create extended acl record from rule '%s': %w", ruleStr, err)
 		}
 	}
 	return nil
@@ -199,7 +199,7 @@
 func ParseEACLRule(table *eacl.Table, rule string) error {
 	r, err := shlex.Split(rule)
 	if err != nil {
-		return fmt.Errorf("can't parse rule '%s': %v", rule, err)
+		return fmt.Errorf("can't parse rule '%s': %w", rule, err)
 	}
 	return parseEACLTable(table, r)
 }
@@ -286,8 +286,10 @@
 				continue
 			}
 
-			var target eacl.Target
-			eacl.SetTargetECDSAKeys(&target, pubs...)
+			target := eacl.NewTargetByRole(eacl.RoleUnspecified)
+			for _, pub := range pubs {
+				target.SetRawSubjects(append(target.RawSubjects(), (*keys.PublicKey)(pub).Bytes()))
+			}
 			targets = append(targets, target)
 		case "address": // targets
 			var (

cmd/neofs-node/config.go

@@ -857,6 +857,7 @@ func (c *cfg) configWatcher(ctx context.Context) {
 				rcfg.AddShard(optsWithID.configID, optsWithID.shOpts)
 			}
 
+			// nolint:contextcheck
 			err = c.cfgObject.cfgLocalStorage.localStorage.Reload(rcfg)
 			if err != nil {
 				c.log.Error("storage engine configuration update", zap.Error(err))

pkg/core/object/replicate.go

@@ -54,7 +54,7 @@
 		// all the errors in the stackitem relate only cases when it is
 		// impossible to use serialized values (too many values, unsupported
 		// types, etc.), unexpected errors at all
-		panic(fmt.Errorf("unexpected stackitem map serialization failure: %v", err))
+		panic(fmt.Errorf("unexpected stackitem map serialization failure: %w", err))
 	}
 
 	return result

pkg/innerring/config_test.go

@@ -540,7 +540,7 @@ func TestIsAutoDeploymentMode(t *testing.T) {
 		err = os.Setenv(envKey, "not a boolean")
 		require.NoError(t, err)
 
-		b, err = isAutoDeploymentMode(v)
+		_, err = isAutoDeploymentMode(v)
 		require.Error(t, err)
 
 		err = os.Setenv(envKey, "false")
@@ -571,7 +571,7 @@ fschain_autodeploy: true
 
 		v.Set("fschain_autodeploy", "not a boolean")
 
-		b, err = isAutoDeploymentMode(v)
+		_, err = isAutoDeploymentMode(v)
 		require.Error(t, err)
 
 		v.Set("fschain_autodeploy", "false")

pkg/innerring/internal/blockchain/blockchain.go

@@ -421,7 +421,7 @@
 		if err != nil {
 			closeErr := bcStorage.Close()
 			if closeErr != nil {
-				err = fmt.Errorf("%w; also failed to close blockchain storage: %v", err, closeErr)
+				err = fmt.Errorf("%w; also failed to close blockchain storage: %w", err, closeErr)
 			}
 		}
 	}()
@@ -518,7 +518,7 @@
 		if err != nil {
 			closeErr := x.storage.Close()
 			if closeErr != nil {
-				err = fmt.Errorf("%w; also failed to close blockchain storage: %v", err, closeErr)
+				err = fmt.Errorf("%w; also failed to close blockchain storage: %w", err, closeErr)
 			}
 		}
 	}()

pkg/innerring/nns_test.go

@@ -63,7 +63,7 @@ func (x *testInvoker) TraverseIterator(sessionID uuid.UUID, iterator *result.Ite
 
 func TestNeoFSNNS_CheckDomainRecord(t *testing.T) {
 	var contractAddr util.Uint160
-	rand.Read(contractAddr[:])
+	_, _ = rand.Read(contractAddr[:])
 	const domain = "l2.l1.tld"
 	searchedRecord := "abcdef"
 

pkg/innerring/processors/netmap/nodevalidation/locode/calls_test.go

@@ -83,9 +83,7 @@ func TestValidator_Verify(t *testing.T) { // test record with valid but random v
 
 			require.NoError(t, validator.Verify(n))
 		})
-
 		t.Run("invalid SN expansion", func(t *testing.T) {
-
 			t.Run("invalid Country", func(t *testing.T) {
 				n := nodeInfoWithSomeAttrs()
 				addLocodeAttr(&n, [2]string{"RU", "SPB"})