engine: option to ignore uninited shards #2953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
End-rey
force-pushed
the
2471-option-to-ignore-uninited-shards
branch
from
2d3090d
to
78df1e5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2953 +/- ##
==========================================
- Coverage 23.53% 23.53% -0.01%
==========================================
Files 776 776
Lines 46583 46602 +19
==========================================
+ Hits 10962 10966 +4
- Misses 34757 34773 +16
+ Partials 864 863 -1 ☔ View full report in Codecov by Sentry. |
End-rey
force-pushed
the
2471-option-to-ignore-uninited-shards
branch
from
78df1e5
to
c8a0349
Compare
cthulhu-rider
requested changes
Sep 30, 2024
End-rey
force-pushed
the
2471-option-to-ignore-uninited-shards
branch
from
c8a0349
to
64ee02a
Compare
Signed-off-by: Andrey Butusov <[email protected]>
Add config bool option `storage.ignore_uninited_shards` which specifies whether uninited shards should be ignored. If option is set to `false`, then immediately fail engine's `Open`/`Init` methods on any shard failure, otherwise continue working. Closes #2471. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
force-pushed
the
2471-option-to-ignore-uninited-shards
branch
from
64ee02a
to
bb04c17
Compare
Add examples of option in `.yaml`, `.json` and `.env` files. Update docs. Add test for this option. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
force-pushed
the
2471-option-to-ignore-uninited-shards
branch
from
bb04c17
to
ef78db2
Compare
cthulhu-rider
approved these changes
Sep 30, 2024
roman-khimov
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2471.