Fix upload to handle attributes FilePath, FileName
#133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatiana-nspcc
requested review from
carpawell,
cthulhu-rider,
roman-khimov and
smallhive
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
==========================================
+ Coverage 13.85% 14.18% +0.32%
==========================================
Files 11 11
Lines 2374 2383 +9
==========================================
+ Hits 329 338 +9
Misses 2013 2013
Partials 32 32 ☔ View full report in Codecov by Sentry. |
roman-khimov
reviewed
Feb 2, 2024
tatiana-nspcc
force-pushed
the
fix-filepath
branch
from
f80d7e3 to
101d7ff
Compare
When we receive headers, they are automatically formatted from any case to only the first letter being uppercase. For example, `FilePath` transforms into `Filepath`. However, NEOFS is case-sensitive for these attributes, which is why we intentionally change them to CamelCase style. We hope this is a temporary workaround and will be removed asap. Connected to nspcc-dev/neofs-http-gw#255. Signed-off-by: Tatiana Nesterenko <[email protected]>
This constant already exists in `object` package. Signed-off-by: Tatiana Nesterenko <[email protected]>
tatiana-nspcc
force-pushed
the
fix-filepath
branch
from
101d7ff to
35d2033
Compare
roman-khimov
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we receive headers, they are automatically formatted from any case to
only the first letter being uppercase. For example,
FilePathtransforms intoFilepath. However, NEOFS is case-sensitive for these attributes, which is whywe intentionally change them to CamelCase style. We hope this is a temporary
workaround and will be removed asap.
Connected to nspcc-dev/neofs-http-gw#255.
Also redundant constant
attributeFilePathis removed.