Disable ACL by default #1018
Merged
Disable ACL by default #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api/handler/put.go
Outdated
| @@ -168,6 +168,9 @@ const ( | |||
| basicACLReadOnly = "public-read" | |||
| basicACLPublic = "public-read-write" | |||
| cannedACLAuthRead = "authenticated-read" | |||
|
|
|||
| amzBucketOwnerField = "x-amz-object-ownership" | |||
There was a problem hiding this comment.
Can't this collide with some real header? I'd expect a bit more magic value here. Although if the rule is always the last one (after default policies) it can't change much.
There was a problem hiding this comment.
It would and there is no guarantee the rule is always be the last, renamed
smallhive
force-pushed
the
1016-object-puts-into-private-buckets-lead-to-eacl-bloat
branch
from
7192f48
to
729dee0
Compare
Closes #1016. Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
1016-object-puts-into-private-buckets-lead-to-eacl-bloat
branch
from
729dee0
to
a792f48
Compare
roman-khimov
reviewed
Nov 2, 2024
roman-khimov
previously approved these changes
Nov 2, 2024
Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
Bucket owner already has full access to the object. We just add the support of the ACL. Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
It's much more useful this way especially if we have many requests with EACLs. ACL status can be deduced from EACL, so we don't need to cache it separately (at least for now, walking through the list takes some time, but it's nothing like getting EACL from the network that we did previously in many cases). Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
1016-object-puts-into-private-buckets-lead-to-eacl-bloat
branch
from
b755aa9
to
8008392
Compare
roman-khimov
approved these changes
Nov 5, 2024
roman-khimov
deleted the
1016-object-puts-into-private-buckets-lead-to-eacl-bloat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1016.