Deduplicate client and pool SyncContainerWithNetwork logic #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallhive
requested review from
roman-khimov,
cthulhu-rider and
carpawell
as code owners
carpawell
reviewed
Jul 7, 2023
cthulhu-rider
approved these changes
Jul 8, 2023
smallhive
force-pushed
the
458-move-synccontainerwithnetwork-to-container
branch
from
783122e
to
2713ba0
Compare
smallhive
force-pushed
the
458-move-synccontainerwithnetwork-to-container
branch
from
2713ba0
to
05b44c5
Compare
closes #458 Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
458-move-synccontainerwithnetwork-to-container
branch
from
05b44c5
to
21e5041
Compare
carpawell
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #458