Extend package API with features usefule for existing apps #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cthulhu-rider
commented
Jul 29, 2023
•
cthulhu-rider
commented
- track adaptations in Upgrade NeoFS SDK module to the latest revision neofs-node#2449
cthulhu-rider
force-pushed
the
feature/new-methods
branch
2 times, most recently
from
3ba061e
to
b99e489
Compare
smallhive
approved these changes
Aug 3, 2023
cthulhu-rider
force-pushed
the
feature/new-methods
branch
from
b99e489
to
b3187fe
Compare
cthulhu-rider
commented
Aug 3, 2023
user/signer.go
Outdated
| return s.id | ||
| // NewStaticSignerWithID creates new [Signer] with specified [ID]. | ||
| func NewStaticSignerWithID(scheme neofscrypto.Scheme, sig []byte, pubKey neofscrypto.PublicKey, id ID) Signer { | ||
| return NewSigner(neofscrypto.NewStaticSigner(scheme, sig, pubKey), id) |
There was a problem hiding this comment.
@smallhive
having NewSigner and neofscrypto.NewStaticSigner: do we really need NewStaticSignerWithID then?
There was a problem hiding this comment.
We have both variants for the usual signer in case if someone wants to set a different user.ID. I think we should save this flexibility here, as a minimum for now
There was a problem hiding this comment.
save this flexibility here
to keep or not to keep NewStaticSignerWithID?
it may be
s := user.NewStaticSignerWithID(scheme, sig, pub, id)
// or
s := user.NewSigner(neofscrypto.NewStaticSigner(scheme, sig, pub), id)does first approach worth a separate function?
There was a problem hiding this comment.
The second option covers my requirements, you may remove NewStaticSignerWithID or mark it obsolete
There was a problem hiding this comment.
ok, lets try to ride w/o it (we can always add if that)
cthulhu-rider
force-pushed
the
feature/new-methods
branch
2 times, most recently
from
1e1ae8f
to
480b739
Compare
roman-khimov
reviewed
Aug 3, 2023
Provide getters of signature scheme, public key and value. Make `WriteToV2` method to decode public key from binary to assert scheme format. New API will allow to avoid `WriteToV2` calls in user space. New unit test checks and shows client-to-server transport over NeoFS API V2 protocol. Signed-off-by: Leonard Lyubich <[email protected]>
Encoding methods of `PublicKey` interface require buffer pre-allocation. In cases where the user does not have a buffer prepared in advance, he has to explicitly create it and encode the key. Helper function `PublicKeyBytes` is added to make code easier. Signed-off-by: Leonard Lyubich <[email protected]>
Previously, package provided constructors for `Signer` instances with RFC 6979 signature scheme only. User may need to construct any `Signer` instance (other scheme or even custom implementation). Add generic constructor `NewSigner` accepting split `neofscrypto.Signer` and `user.ID`. Add two constructors from standard `ecdsa.PrivateKey` with an explanation that the user ID is resolved automatically. Signed-off-by: Leonard Lyubich <[email protected]>
Signature is used for user authentication so access to public key is required. Digital signature bytes may still be unexported because they are only useful for `VerifySignature` method. Add `IssuerPublicKeyBytes` method returning binary-encoded public key of the session issuer. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
feature/new-methods
branch
from
480b739
to
577b2d6
Compare
roman-khimov
approved these changes
Aug 4, 2023
carpawell
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.