Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store protocol-related code in proto dir #599

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Store protocol-related code in proto dir #599

merged 1 commit into from
Jul 16, 2024

Conversation

cthulhu-rider
Copy link
Contributor

@cthulhu-rider
Store protocol-related code in proto dir
527c964 
`api` is not clear enough.

Signed-off-by: Leonard Lyubich <[email protected]>
carpawell
carpawell reviewed Jul 15, 2024
View reviewed changes
Copy link
Member

@carpawell carpawell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not internal/proto?

@roman-khimov
Copy link
Member

We'll think about internalization after node conversion.

--- FAIL: TestFloat (0.00s)
    encoding_test.go:176: 
        	Error Trace:	/home/runner/work/neofs-sdk-go/neofs-sdk-go/internal/proto/encoding_test.go:176
        	            				/home/runner/work/neofs-sdk-go/neofs-sdk-go/internal/proto/encoding_test.go:297
        	Error:      	Not equal: 
        	            	expected: NaN
        	            	actual  : NaN
        	Test:       	TestFloat
        	Messages:   	num=152534972,val=NaN
FAIL

@cthulhu-rider
Copy link
Contributor Author

test is fixed in other PR #597. I didnt think it will stuck for so long

@roman-khimov roman-khimov merged commit a4360ae into master Jul 16, 2024
9 of 10 checks passed
@roman-khimov roman-khimov deleted the move-proto-dir branch July 16, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carpawell carpawell carpawell left review comments

@roman-khimov roman-khimov roman-khimov approved these changes

@smallhive smallhive Awaiting requested review from smallhive smallhive is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cthulhu-rider @roman-khimov @carpawell