workflows: run tests for master #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
requested review from
cthulhu-rider,
smallhive and
carpawell
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #620 +/- ##
==========================================
+ Coverage 54.38% 54.39% +0.01%
==========================================
Files 164 164
Lines 19152 19152
==========================================
+ Hits 10416 10418 +2
+ Misses 8338 8335 -3
- Partials 398 399 +1 ☔ View full report in Codecov by Sentry. |
carpawell
reviewed
Aug 21, 2024
.github/workflows/tests.yml
Outdated
| branches: | ||
| - master | ||
| paths-ignore: | ||
| - '*.md' |
There was a problem hiding this comment.
Suggested change
| - '*.md' | |
| - '**/*.md' |
not sure it changes anything to us now but this it how it is done below
Sometimes merged code != PR code and we want to have some proper statistics for covertage as well (it doesn't have proper data for master now because we're not collecting it). Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
test-master
branch
from
5d39e22
to
d8fea6e
Compare
carpawell
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes merged code != PR code and we want to have some proper statistics for covertage as well (it doesn't have proper data for master now because we're not collecting it).