Dependency upgrade #621
Merged
Dependency upgrade #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It needs to be done from time to time and upgrading it at the same time with Go is always nice. Signed-off-by: Roman Khimov <[email protected]>
The official Go package has moved to github.com/antlr4-go/antlr and newer version requires code regeneration. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
requested review from
cthulhu-rider,
smallhive and
carpawell
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #621 +/- ##
==========================================
- Coverage 54.38% 53.93% -0.45%
==========================================
Files 164 164
Lines 19152 19222 +70
==========================================
- Hits 10416 10368 -48
- Misses 8338 8415 +77
- Partials 398 439 +41 ☔ View full report in Codecov by Sentry. |
We need a custom dialer here, so just switching to NewClient doesn't work:
init service=neo.fs.v2.object.ObjectService/op=Replicate RPC: failed to exit idle mode: dns resolver: missing address
Signed-off-by: Roman Khimov <[email protected]>
smallhive
approved these changes
Aug 22, 2024
carpawell
approved these changes
Aug 22, 2024
|
No. Except for some maybe. Fingers crossed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.