pool: Drop opening no-op sessions #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonard Lyubich <[email protected]>
`Table` contains no session token and signature. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
proxy-token
branch
from
7dd7021
to
543ebdc
Compare
cthulhu-rider
changed the title
cthulhu-rider
requested review from
roman-khimov,
smallhive and
carpawell
as code owners
roman-khimov
approved these changes
Sep 16, 2024
|
|
||
| func (x objectSearchOnlyClientWrapper) getClient() (sdkClientInterface, error) { return x.c, nil } | ||
|
|
||
| func TestPool_ObjectSearchInit(t *testing.T) { |
There was a problem hiding this comment.
Why duplicating prologue in these? Likely we can have less code and still separate subtests for different operations.
There was a problem hiding this comment.
prefer independent tests for methods
smallhive
reviewed
Sep 17, 2024
|
Sessions are still there where they're needed. It's just that most requests can be handled fine without sessions. |
smallhive
approved these changes
Sep 17, 2024
Currently, there are only two NeoFS operations supporting sessions: object creation (PUT) and removal (DELETE). The latter is essentially creation of the tombstone object. Sessions are used in cases when client requests trusted storage node to form an object and sign it via so-called private session key. Public part of this key is signed by original client in the attached session token. This makes no sense for any other op because server does nothing on behalf of the client, it just executes his request. Previously, pool of NeoFS clients could open session for any object op incl. reading ones. As said, this broke nothing, but was completely redundant. This drops session opening for any op except PUT/DELETE to increase pool's efficiency and relieve network pressure. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
proxy-token
branch
from
543ebdc
to
12a4bf2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #623 +/- ##
==========================================
+ Coverage 53.93% 54.13% +0.19%
==========================================
Files 164 164
Lines 19222 19193 -29
==========================================
+ Hits 10368 10390 +22
+ Misses 8415 8358 -57
- Partials 439 445 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.