Org-wide linter #625
Merged
Org-wide linter #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
requested review from
cthulhu-rider,
smallhive and
carpawell
as code owners
Signed-off-by: Roman Khimov <[email protected]>
netmap/aggregator.go:84:24 predeclared param min has same name as predeclared identifier Signed-off-by: Roman Khimov <[email protected]>
object/error_test.go:22:15 errorlint type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors client/example_container_put_test.go:49:31 errorlint non-wrapping format verb for fmt.Errorf. Use `%w` to format errors netmap/network_info.go:320:73 errorlint non-wrapping format verb for fmt.Errorf. Use `%w` to format errors Signed-off-by: Roman Khimov <[email protected]>
reputation/trust.go:197:53 misspell `incorect` is a misspelling of `incorrect` Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
object/slicer/slicer_test.go:856:24 contextcheck Non-inherited new context, use function like `context.WithXXX` instead object/slicer/slicer_test.go:889:24 contextcheck Non-inherited new context, use function like `context.WithXXX` instead object/slicer/slicer_test.go:928:24 contextcheck Non-inherited new context, use function like `context.WithXXX` instead Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
org-linter
branch
from
930a201
to
0656ac6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #625 +/- ##
==========================================
+ Coverage 53.90% 53.93% +0.02%
==========================================
Files 164 164
Lines 19249 19249
==========================================
+ Hits 10377 10381 +4
+ Misses 8430 8426 -4
Partials 442 442 ☔ View full report in Codecov by Sentry. |
smallhive
approved these changes
Sep 11, 2024
carpawell
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.