netmap: Improve testing and increase coverage #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test each method independently and use fixed reference values/binary. Also maximize the coverage. Signed-off-by: Leonard Lyubich <[email protected]>
Previous condition in `NetworkInfo.ReadFromV2` method was wrong and unreachable. Signed-off-by: Leonard Lyubich <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #627 +/- ##
==========================================
+ Coverage 53.93% 54.35% +0.41%
==========================================
Files 164 164
Lines 19222 19193 -29
==========================================
+ Hits 10368 10432 +64
+ Misses 8415 8327 -88
+ Partials 439 434 -5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
netmap
branch
from
08c052f
to
2d16ee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.