Skip to content

Commit

Permalink
fix s3 acl test and logging in assert_s3_acl (#598)
Browse files Browse the repository at this point in the history
  • Loading branch information
roman-khimov committed Sep 4, 2023
2 parents e95c173 + 6852478 commit 1b8a0b3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pytest_tests/helpers/s3_helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,4 +157,4 @@ def assert_s3_acl(acl_grants: list, permitted_users: str):
permission = acl_grant.get("Permission")
assert permission == "FULL_CONTROL", "Only CanonicalUser should have FULL_CONTROL"
else:
logger.error("FULL_CONTROL is given to All Users")
raise AssertionError("FULL_CONTROL is given to All Users")
2 changes: 1 addition & 1 deletion pytest_tests/testsuites/services/s3_gate/test_s3_object.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def test_s3_copy_acl(self, bucket, simple_object_size):

with allure.step("Copy object and check acl attribute"):
copy_obj_path = s3_gate_object.copy_object_s3(
self.s3_client, bucket, obj_key, ACL="public-read-write"
self.s3_client, bucket, obj_key, ACL="private"
)
obj_acl = s3_gate_object.get_object_acl_s3(self.s3_client, bucket, copy_obj_path)
assert_s3_acl(acl_grants=obj_acl, permitted_users="CanonicalUser")
Expand Down

0 comments on commit 1b8a0b3

Please sign in to comment.