tests: network config changes via neofs-adm, fixes #548

Signed-off-by: Evgeniy Zayats <[email protected]>

pytest_tests/testsuites/network/test_config_changes.py

@@ -0,0 +1,144 @@
+from typing import Union
+
+import allure
+import pytest
+from cluster_test_base import ClusterTestBase
+from common import NEOFS_ADM_CONFIG_PATH, NEOFS_ADM_EXEC
+from neofs_testlib.cli import NeofsAdm
+from python_keywords.neofs_verbs import get_netmap_netinfo
+
+CONFIG_KEYS_MAPPING = {
+    "MaxObjectSize": "maximum_object_size",
+    "BasicIncomeRate": "storage_price",
+    "AuditFee": "audit_fee",
+    "EpochDuration": "epoch_duration",
+    "ContainerFee": "container_fee",
+    "EigenTrustIterations": "number_of_eigentrust_iterations",
+    "EigenTrustAlpha": "eigentrust_alpha",
+    "InnerRingCandidateFee": "inner_ring_candidate_fee",
+    "WithdrawFee": "withdrawal_fee",
+    "HomomorphicHashingDisabled": "homomorphic_hashing_disabled",
+    "MaintenanceModeAllowed": "maintenance_mode_allowed",
+}
+
+
+@allure.title("Network configuration changes via neofs-adm")
+@pytest.mark.network_config
+class TestNetworkConfigChange(ClusterTestBase):
+    @pytest.mark.parametrize(
+        "key, value",
+        [
+            ("MaxObjectSize", 1048576),
+            ("BasicIncomeRate", 50000000),
+            ("AuditFee", 5000),
+            ("EpochDuration", 480),
+            ("ContainerFee", 2000),
+            pytest.param(
+                "ContainerAliasFee",
+                5000,
+                marks=pytest.mark.skip(
+                    reason="https://github.com/nspcc-dev/neofs-testcases/issues/630"
+                ),
+            ),
+            ("EigenTrustIterations", 8),
+            ("EigenTrustAlpha", 0.2),
+            ("InnerRingCandidateFee", 5000000000),
+            ("WithdrawFee", 200000000),
+            ("HomomorphicHashingDisabled", True),
+            ("MaintenanceModeAllowed", True),
+        ],
+    )
+    def test_config_update_single_value(
+        self, key: str, value: Union[str, int, bool], clean_config: None
+    ):
+        allure.dynamic.title(f"Set '{key}' to '{value}'")
+        self._set_and_verify_config_keys(**{key: value})
+
+    @allure.title("Multiple network config keys can be changed at once")
+    def test_config_update_multiple_values(self):
+        new_key_value_pairs = {
+            "MaxObjectSize": 1048576,
+            "BasicIncomeRate": 50000000,
+            "AuditFee": 5000,
+        }
+        self._set_and_verify_config_keys(**new_key_value_pairs)
+
+    @pytest.mark.parametrize(
+        "key, value",
+        [
+            ("MaxObjectSize", "VeryBigSize"),
+            ("BasicIncomeRate", False),
+            ("HomomorphicHashingDisabled", 0.2),
+        ],
+    )
+    @allure.title("Set network config key to invalid value")
+    def test_config_set_invalid_value(self, key: str, value: Union[str, int, bool]):
+        self._set_and_verify_config_keys(**{key: value})
+
+    @allure.title("Set multiple network config keys to invalid values with force")
+    def test_config_set_multiple_invalid_values(self):
+        self._set_and_verify_config_keys(
+            **{"MaxObjectSize": "VeryBigSize", "BasicIncomeRate": False}, force=True
+        )
+
+    @allure.title("Set network config unknown key")
+    def test_config_set_unknown_key(self):
+        with pytest.raises(RuntimeError, match=f".*key is not well-known.*"):
+            self._set_and_verify_config_keys(**{"unknown_key": 120})
+
+    @allure.title("Set network config unknown key with force")
+    def test_config_force_set_unknown_key(self):
+        self._set_and_verify_config_keys(**{"unknown_key": 120}, force=True)
+
+    def _set_and_verify_config_keys(
+        self, force: bool = False, **key_value_pairs: dict[str, Union[str, int, bool]]
+    ):
+        ir_node = self.cluster.ir_nodes[0]
+        morph_chain = self.cluster.morph_chain_nodes[0]
+        neofsadm = NeofsAdm(
+            shell=ir_node.host.get_shell(),
+            neofs_adm_exec_path=NEOFS_ADM_EXEC,
+            config_file=NEOFS_ADM_CONFIG_PATH,
+        )
+
+        with allure.step(f"Set {key_value_pairs} via neofs-adm"):
+            force_str = f"--force " if force else ""
+            keys_values_str = " ".join(
+                [f"{key}={str(value).lower()}" for key, value in key_value_pairs.items()]
+            )
+
+            neofsadm.morph.set_config(
+                rpc_endpoint=morph_chain.get_endpoint(),
+                alphabet_wallets="/".join(ir_node.get_wallet_path().split("/")[:-1]),
+                post_data=f"{force_str}{keys_values_str}",
+            )
+
+            storage_node = self.cluster.storage_nodes[0]
+            net_info = get_netmap_netinfo(
+                wallet=storage_node.get_wallet_path(),
+                wallet_config=storage_node.get_wallet_config_path(),
+                endpoint=storage_node.get_rpc_endpoint(),
+                shell=storage_node.host.get_shell(),
+            )
+
+            for key, value in key_value_pairs.items():
+                assert net_info[CONFIG_KEYS_MAPPING[key]] == value
+
+    @pytest.fixture(scope="function")
+    def clean_config(self) -> None:
+        with allure.step(f"Get config contents before test"):
+            storage_node = self.cluster.storage_nodes[0]
+            net_info = get_netmap_netinfo(
+                wallet=storage_node.get_wallet_path(),
+                wallet_config=storage_node.get_wallet_config_path(),
+                endpoint=storage_node.get_rpc_endpoint(),
+                shell=storage_node.host.get_shell(),
+            )
+            original_key_value_pairs = {}
+            for key, value in CONFIG_KEYS_MAPPING.items():
+                original_key_value_pairs[key] = net_info[value]
+
+        yield
+
+        with allure.step(f"Change config contents back to original via neofs-adm"):
+            self._set_and_verify_config_keys(**original_key_value_pairs)