Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging level in the assert_s3_acl #598

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Fix logging level in the assert_s3_acl #598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e2aedd
s3_gate: Fix the test_s3_copy_acl test
vvarg229 Sep 2, 2023
6852478
helpers: raise AssertionError
vvarg229 Sep 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytest_tests/helpers/s3_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,4 +157,4 @@ def assert_s3_acl(acl_grants: list, permitted_users: str):
permission = acl_grant.get("Permission")
assert permission == "FULL_CONTROL", "Only CanonicalUser should have FULL_CONTROL"
else:
logger.error("FULL_CONTROL is given to All Users")
raise AssertionError("FULL_CONTROL is given to All Users")
2 changes: 1 addition & 1 deletion pytest_tests/testsuites/services/s3_gate/test_s3_object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def test_s3_copy_acl(self, bucket, simple_object_size):

with allure.step("Copy object and check acl attribute"):
copy_obj_path = s3_gate_object.copy_object_s3(
self.s3_client, bucket, obj_key, ACL="public-read-write"
self.s3_client, bucket, obj_key, ACL="private"
)
obj_acl = s3_gate_object.get_object_acl_s3(self.s3_client, bucket, copy_obj_path)
assert_s3_acl(acl_grants=obj_acl, permitted_users="CanonicalUser")
Expand Down
Loading