Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/venv activation #668

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

carpawell
Copy link
Member

I have been looking at errors like

patch -R --dry-run -p1 -s -f -d venv.local-pytest/bin/ < build_assets/activate.patch || patch -p1 -d venv.local-pytest/bin/ < build_assets/activate.patch
2 out of 2 hunks FAILED

and

make: *** No rule to make target 'env'.  Stop.
deactivate:unset:28: not enough arguments
(venv.local-pytest)

for years already. Double check, please. The whole approach looks strange to me but fixing smth is never bad.

- Do not deactivate venv's envs if `DEVENV_PATH` is not set yet;
- Fix patch applying: I just do not understand what (and why) the removed lines
did, and the current version seems to do the same, and it is easy to use it and
understand what it does.

Signed-off-by: Pavel Karpy <[email protected]>
@roman-khimov roman-khimov merged commit 9c89ace into master Nov 3, 2023
1 check passed
@roman-khimov roman-khimov deleted the fix/patching-applying-and-env-deactivation branch November 3, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants