helpers, s3_gate: Fix acl tests #669
Conversation
vvarg229
requested review from
roman-khimov,
cthulhu-rider and
evgeniiz321
as code owners
pytest_tests/helpers/s3_helper.py
Outdated
| "public-read": "WRITE", | ||
| "grant-read": "WRITE", | ||
| "private": "WRITE", |
There was a problem hiding this comment.
AWS documentation is so messy, but according to Canned ACL, I tend to think, these rows should be FULL_CONTROL as well
There was a problem hiding this comment.
AWS documentation is so messy, but according to Canned ACL, I tend to think, these rows should be FULL_CONTROL as well
Then you need to fix that in the s3-gw repo too
There was a problem hiding this comment.
That's the way. But I think we should discuss it with @evgeniiz321, to be sure we are on the same page with documentation understanding.
There was a problem hiding this comment.
AWS documentation is so messy, but according to Canned ACL, I tend to think, these rows should be FULL_CONTROL as well
Fixed
|
Rebase, fix problems and let's move on. |
vvarg229
force-pushed
the
s3-gw-acl
branch
5 times, most recently
from
4b56fc3
to
bb00665
Compare
The neofs-s3-gw repository has made changes to how acl works. This commit changes the tests so that they work correctly with the new acl rules. Signed-off-by: Oleg Kulachenko <[email protected]>
Fixed, tests result: https://http.fs.neo.org/7ZVSQHtioVRiDT2btN9xEmQhczXV9vryCEAHUawfD8Sc/126-1700220863/index.html |
The neofs-s3-gw repository has made changes to how acl works. This commit changes the tests so that they work correctly with the new acl rules.
Tests result:
https://http.fs.neo.org/7ZVSQHtioVRiDT2btN9xEmQhczXV9vryCEAHUawfD8Sc/126-1700220863/index.html
Important:
Tests on the current master will crash, this change will only work with a recent s3-gw