Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some s3 tests to use dynamic env #680

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Update some s3 tests to use dynamic env #680

merged 4 commits into from
Dec 22, 2023

Conversation

evgeniiz321
Copy link
Contributor

This is an example of how we can move tests to use dynamic environment instead of a static dev-env. In parallel we can refactor existing non optimal/legacy code.

  1. Separate directory for new tests and library code - dynamic_env_pytest_tests
  2. In the meantime we reuse some existing code located in pytest_tests/* robot/*
  3. During tests moving to a new dynamic env - we refactor existing legacy code and move it to dynamic_env_pytest_tests/lib as well.
  4. For new tests at dynamic_env_pytest_tests we create a separate validation inside this repo

@evgeniiz321 evgeniiz321 self-assigned this Dec 18, 2023
@evgeniiz321 evgeniiz321 marked this pull request as draft December 18, 2023 04:22
This was referenced Dec 18, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@evgeniiz321 evgeniiz321 force-pushed the ezayats/dynamic_env branch 8 times, most recently from d55f4cd to fe41d14 Compare December 20, 2023 01:58
@evgeniiz321 evgeniiz321 marked this pull request as ready for review December 20, 2023 02:09
@evgeniiz321 evgeniiz321 changed the title EXAMPLE: Update some s3 tests to use dynamic env Update some s3 tests to use dynamic env Dec 20, 2023
vvarg229
vvarg229 requested changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@vvarg229 vvarg229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to separate into different commits the CI file, the "library" for the dynamic_env_pytest_tests and new tests.

vvarg229
vvarg229 requested changes Dec 20, 2023
View reviewed changes
robot/resources/files/container_policy.json Outdated Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
vvarg229
vvarg229 requested changes Dec 20, 2023
View reviewed changes
.github/workflows/run-tests.yml Outdated Show resolved Hide resolved
.github/workflows/run-tests.yml Outdated Show resolved Hide resolved
.github/workflows/run-tests.yml Outdated Show resolved Hide resolved
.github/workflows/run-tests.yml Outdated Show resolved Hide resolved
Evgeniy Zayats added 3 commits December 20, 2023 20:36
Bump neofs-testlib 1.1.11 -> 1.1.14
8f4dc84 
Tenacity dependency is also updated due to new version used by
new neofs-testlib version.

Signed-off-by: Evgeniy Zayats <[email protected]>
Add new dynamic env library for custom dev env deployments
d401fa0 
Signed-off-by: Evgeniy Zayats <[email protected]>
Migrate s3 acl tests to a new dynamic env
665249e 
Signed-off-by: Evgeniy Zayats <[email protected]>
@evgeniiz321
Copy link
Contributor Author

commits were separated

@evgeniiz321 evgeniiz321 merged commit ecc3130 into nspcc-dev:master Dec 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvarg229 vvarg229 vvarg229 approved these changes

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov is a code owner

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

Assignees

@evgeniiz321 evgeniiz321

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgeniiz321 @vvarg229