Enable pprof and prometheus for all services #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeniiz321
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
carpawell
reviewed
Sep 11, 2024
There was a problem hiding this comment.
@evgeniiz321, is it possible to add them to the env_details file too? I use it a lot. Also since we are talking about it, it would be nice to make it more standard: for main services it has "RPC", "Endpoint" or "Address" names for the same things in fact. A control port is named "GRPC address" or "Control gRPC endpoint" depending on the service. Can create another issue if necessary.
evgeniiz321
force-pushed
the
ezayats/metrics
branch
from
aca34b5
to
40ad82d
Compare
|
@carpawell updated env_details, addresses will be displayed there as well. As for standardization - pls open another issue. |
roman-khimov
approved these changes
Sep 11, 2024
carpawell
approved these changes
Sep 12, 2024
closes #847 Signed-off-by: Evgeniy Zayats <[email protected]>
evgeniiz321
force-pushed
the
ezayats/metrics
branch
from
40ad82d
to
1d5b0ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #847