tests: verify SN can be stopped using SIGTERM #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evgeniy Zayats <[email protected]>
evgeniiz321
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
roman-khimov
reviewed
Nov 5, 2024
| @@ -56,7 +56,7 @@ def test_storage_node_failover( | |||
| if hard_restart: | |||
| node_to_stop.kill() | |||
| else: | |||
| node_to_stop.stop() | |||
| node_to_stop.stop(force=False) | |||
There was a problem hiding this comment.
But if it fails, we're stuck here, right? Maybe it's better to pass/check some return code when node is killed.
There was a problem hiding this comment.
no, if it fails - we will get a TimeoutError after 60 seconds
There was a problem hiding this comment.
flag is about what to do when we get this TimeoutError - with force - we use kill, without force - we raise an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.