Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac assign employee training #31

Merged
merged 3 commits into from
Apr 19, 2020
Merged

Conversation

macgibbons
Copy link
Collaborator

@macgibbons macgibbons commented Apr 17, 2020

Description

Added an assignment method in employeeController and added an assignment view. This allows the user to assign an employee to a training program when viewing said employees detail page
Closes half of #16 - need to work on the multiselect

Type of change

  • New feature (non-breaking change which adds functionality)

Testing Instructions

Navigate to an employees detail page. You should see an option to assign . Click this link and you will be taken to a form to assign the employee to a training program. The drop down should have a list of all training programs that are in the future and that are not at max capacity. Make a selection and click assign. Now if you navigate to that training program's detail view you should see that employee in the list of attending employees.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings or errors
  • I have added test instructions that prove my fix is effective or that my feature works

Copy link
Collaborator

@casescally casescally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great!

@macgibbons macgibbons marked this pull request as ready for review April 17, 2020 19:29
@ETamez173 ETamez173 self-assigned this Apr 19, 2020
@ETamez173
Copy link
Collaborator

Tested each feature and it is working as intended.

@ETamez173 ETamez173 closed this Apr 19, 2020
@ETamez173 ETamez173 reopened this Apr 19, 2020
@ETamez173 ETamez173 merged commit 08ab917 into master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants