Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update target frameworks and other infrastructure changes #831

Merged
merged 9 commits into from
Nov 2, 2024

Conversation

Romfos
Copy link
Contributor

@Romfos Romfos commented Sep 14, 2024

changes:

  • [Breaking Change] Update target frameworks: .NET 8, .NET Standard 2.0
  • Drop EOL .NET 6/7 platforms from testing matrix
  • Update github actions steps versions
  • [Breaking Change] Remove legacy obsolete API
  • [Breaking Change] Mark as obsolete api CompatArg with pre c# 7.0 support

This PR is a first part of preparation to version 6.0.0 #830

please, join to discussion

Copy link
Member

@dtchepak dtchepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Romfos , thanks! I've left a few comments/questions but probably ok to merge as-is.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
src/NSubstitute/NSubstitute.csproj Show resolved Hide resolved
src/NSubstitute/NSubstitute.csproj Show resolved Hide resolved
src/NSubstitute/NSubstitute.csproj Show resolved Hide resolved
@dtchepak
Copy link
Member

I will merge this once v5.3 PR is merged and released. 👍

@dtchepak
Copy link
Member

@Romfos Thanks for all your contributions to NSub. Would you be open to joining the contributors team?

No obligations in terms of amount of involvement or anything. It can be as little or as much as you like.

You are welcome to email [email protected] if you have any questions. 🙇

@Romfos
Copy link
Contributor Author

Romfos commented Oct 27, 2024

@Romfos Thanks for all your contributions to NSub. Would you be open to joining the contributors team?

No obligations in terms of amount of involvement or anything. It can be as little or as much as you like.

You are welcome to email [email protected] if you have any questions. 🙇

Yea, as I see - I already have Contributor status

@Romfos Romfos reopened this Oct 29, 2024
@Romfos Romfos requested a review from dtchepak October 29, 2024 08:08
@dtchepak dtchepak merged commit 72d146d into nsubstitute:main Nov 2, 2024
12 checks passed
@dtchepak
Copy link
Member

dtchepak commented Nov 2, 2024

@Romfos Thanks for all your contributions to NSub. Would you be open to joining the contributors team?
No obligations in terms of amount of involvement or anything. It can be as little or as much as you like.
You are welcome to email [email protected] if you have any questions. 🙇

Yea, as I see - I already have Contributor status

Thanks @Romfos ! Invite sent :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants