Get us back to working with scaleX or scaleX()

nteract · Jan 26, 2022 · ec02017 · ec02017
1 parent 4509169
commit ec02017
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/src/components/OrdinalFrame.tsx b/src/components/OrdinalFrame.tsx
@@ -52,7 +52,7 @@ const defaultProps: Partial<OrdinalFrameProps> = {
   size: [500, 500],
   className: "",
   data: [],
-  oScaleType: scaleBand,
+  oScaleType: scaleBand(),
   rScaleType: scaleLinear,
   type: "none",
   useSpans: false,

diff --git a/src/components/processing/ordinal.tsx b/src/components/processing/ordinal.tsx
@@ -303,9 +303,13 @@ export const calculateOrdinalFrame = (
     { total: 0 }
   )
 
-  const castOScaleType = oScaleType as unknown as Function
+  const castOScaleType = oScaleType as unknown as any
 
-  const oScale = dynamicColumnWidth ? scaleOrdinal() : castOScaleType()
+  const oScale = dynamicColumnWidth
+    ? scaleOrdinal()
+    : castOScaleType?.domain
+    ? castOScaleType
+    : castOScaleType()
 
   oScale.domain(oExtent)
 
@@ -495,10 +499,11 @@ export const calculateOrdinalFrame = (
     adjustedSize[0]
   ]
 
-  const castRScaleType = rScaleType as unknown as Function
+  const castRScaleType = rScaleType as unknown as any
 
-  const instantiatedRScaleType = rScaleType.domain
-    ? rScaleType
+  // if rScaleType has a domain that means it's instantiated, otherwise, it needs to be instantiated
+  const instantiatedRScaleType = castRScaleType.domain
+    ? castRScaleType
     : castRScaleType()
 
   const zeroCheck = instantiatedRScaleType(0)

diff --git a/src/components/types/ordinalTypes.ts b/src/components/types/ordinalTypes.ts
@@ -80,7 +80,7 @@ export interface OrdinalFrameProps extends GeneralFrameProps {
   renderMode?: object | string | accessorType<string | object>
   summaryRenderMode?: object | string | accessorType<string | object>
   pixelColumnWidth?: number
-  oScaleType?: () => ScaleBand<string>
+  oScaleType?: any
   rScaleType?: () => ScaleLinear<number, number>
   data: Array<object | number>
   oPadding?: number