clippy

Cargo.toml

@@ -27,7 +27,7 @@ frame-trace = []
 ntex = "0.7.3"
 ntex-amqp-codec = "0.9.0"
 
-bitflags = "1.3"
+bitflags = "2.4"
 derive_more = "0.99"
 log = "0.4"
 pin-project-lite = "0.2"

codec/src/codec/decode.rs

@@ -171,7 +171,7 @@ impl DecodeFormatted for char {
 impl DecodeFormatted for DateTime<Utc> {
     fn decode_with_format(input: &mut Bytes, fmt: u8) -> Result<Self, AmqpParseError> {
         validate_code!(fmt, codec::FORMATCODE_TIMESTAMP);
-        be_read!(input, read_i64, 8).map(datetime_from_millis)
+        be_read!(input, read_i64, 8).and_then(datetime_from_millis)
     }
 }
 
@@ -520,17 +520,21 @@ fn decode_compound32(input: &mut Bytes) -> Result<CompoundHeader, AmqpParseError
     Ok(CompoundHeader { size, count })
 }
 
-fn datetime_from_millis(millis: i64) -> DateTime<Utc> {
+fn datetime_from_millis(millis: i64) -> Result<DateTime<Utc>, AmqpParseError> {
     let seconds = millis / 1000;
     if seconds < 0 {
         // In order to handle time before 1970 correctly, we need to subtract a second
         // and use the nanoseconds field to add it back. This is a result of the nanoseconds
         // parameter being u32
         let nanoseconds = ((1000 + (millis - (seconds * 1000))) * 1_000_000).unsigned_abs();
-        Utc.timestamp(seconds - 1, nanoseconds as u32)
+        Utc.timestamp_opt(seconds - 1, nanoseconds as u32)
+            .earliest()
+            .ok_or(AmqpParseError::DatetimeParseError)
     } else {
         let nanoseconds = ((millis - (seconds * 1000)) * 1_000_000).unsigned_abs();
-        Utc.timestamp(seconds, nanoseconds as u32)
+        Utc.timestamp_opt(seconds, nanoseconds as u32)
+            .earliest()
+            .ok_or(AmqpParseError::DatetimeParseError)
     }
 }
 

codec/src/error.rs

@@ -25,6 +25,7 @@ pub enum AmqpParseError {
     #[display(fmt = "Unknown {:?} option.", "_0")]
     UnknownEnumOption(&'static str),
     UuidParseError,
+    DatetimeParseError,
     #[from(ignore)]
     #[display(fmt = "Unexpected type: '{:?}'", "_0")]
     UnexpectedType(&'static str),

codec/src/message/mod.rs

@@ -6,4 +6,4 @@ mod message;
 pub use self::body::MessageBody;
 pub use self::message::Message;
 
-pub(self) const SECTION_PREFIX_LENGTH: usize = 3;
+const SECTION_PREFIX_LENGTH: usize = 3;

src/dispatcher.rs

@@ -64,9 +64,7 @@ where
 
     fn call_control_service(&self, frame: ControlFrame) {
         let fut = self.ctl_service.call_static(frame.clone());
-        self.ctl_fut
-            .borrow_mut()
-            .push((frame, Box::pin(async move { fut.await })));
+        self.ctl_fut.borrow_mut().push((frame, Box::pin(fut)));
         self.ctl_queue.waker.wake();
     }
 

src/lib.rs

@@ -1,4 +1,4 @@
-#![deny(rust_2018_idioms)]
+#![deny(rust_2018_idioms, warnings, unreachable_pub)]
 #![allow(clippy::type_complexity)]
 
 #[macro_use]